Problem/Motivation

Pierre Dureau has been doing great work in supporting the Single Directory Components initiative.

His expertise in building design system implementations, and his work on discussing and shaping Single Directory Components make him an ideal candidate for maintaining it now that it's part of the Theme API.

The proposal is to add Pierre to the Theme API maintainers, but have his responsibilities focused on Single Directory Components.

He indicated he is interested in this.

Steps to reproduce

Proposed resolution

  • Discuss.
  • Approval from committers.
  • Patch, review, commit.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3447206

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

e0ipso created an issue. See original summary.

e0ipso’s picture

Pierre, like I already told you, thanks for being part of this community, and for putting up with me 😜

mherchel’s picture

+1 on adding @pdureau as maintainer. His help during development was invaluable.

He is not the only one that should be added IMHO, cross linking #3447487: Add e0ipso as a co-maintainer of core theme system with focus on SDC

nod_’s picture

Very much +1

ckrina’s picture

Huge +1. Beyond other qualities, his willingness to coordinate with others make him a great maintainer.

xjm’s picture

Sounds like a great fit!

To commit this, we need @pdureau to confirm reading the Drupal core governance, and agreeing to the responsibilities listed under:

(Plus an MR to add him to MAINTAINERS.txt.)

Thanks everyone!

xjm’s picture

Issue tags: +Project governance
oldeb’s picture

Big +1 !

grimreaper’s picture

Hi,

+1 on this too.

Working since 5 years with Pierre on UI Suite and following him on his other projects like https://dilla.io/, I can't count the architecture discussions we have on Drupal rendering system, UI Suite and new technological ideas.

sharique’s picture

Big +1 from me also.

finnsky’s picture

+1
Thank you!

gaydabura’s picture

+1

vmoskalenko’s picture

Absolutely agree ! For more than 5 years of working with Pierre, he daily shows great professionalism in architectural solutions, both in the integration of UI Suite and in general.

pdureau’s picture

Hello all, thanks for all the love ♡♡♡

Hi @xjm, I have read the 3 chapters of drupal-core.md and I agree with them.

If I will have the honour of joining the maintainer team of Drupal\Core\Theme sub-system, I will come with my skills and my passion, and also some proposals I wish to discuss with the team:

  • GOAL 1: make Drupal themes as reusable between projects as Drupal modules, let's witness the emergence of a vibrant ecosystem of contrib themes, by:
    • promoting practices where there is no business specific or project specific code in the theme, so as few references to config entities as possible
  • GOAL 2: make Drupal themes friendlier for front devs, by:
    • reducing the need of PHP code in theme. PHP is not a front dev's language
    • reducing the use of ThemeManager::render() and related mechanisms (hook_theme, template suggestions, prerpocesses...) in favour of Renderer:render()
    • leveraging design system philosophy by promoting SDC as the main way of authoring template based renderable & by introducing other declarative UI artefacts (style utilities, modes, CSS variables, iconsets...)
  • GOAL 3: make Drupal themes more integrated to Drupal site building, thanks to the upcoming experience builder, by:
    • removing the need of declaring regions in the info.yml file and leveraging SDC components and Layout API instead
    • making the new design system artefacts as easy to load and plug as the SDC components

Cheers,

g4mbini’s picture

What a huge and great news ! You deserve it so much Pierre and I'm sur you'll do a great job !

++++++++1

nicxvan’s picture

This is exciting!

mherchel’s picture

Comment #14 is getting me all excited! 😅😍😆

celdia’s picture

+1
He deserves it, Pierre !

eme’s picture

+1 of course !

just_like_good_vibes’s picture

big +1
thanks for being part of the community
and what you do

ckrina’s picture

Status: Active » Needs review
ckrina’s picture

Status: Needs review » Reviewed & tested by the community

Actually as per #14 I think this can be moved as RTBC to be committed.

  • nod_ committed c87b28be on 10.3.x
    Issue #3447206 by pdureau: Add pdureau as a co-maintainer for the Theme...

  • nod_ committed 7295751b on 10.4.x
    Issue #3447206 by pdureau: Add pdureau as a co-maintainer for the Theme...

  • nod_ committed 07e25d69 on 11.0.x
    Issue #3447206 by pdureau: Add pdureau as a co-maintainer for the Theme...

  • nod_ committed 6eb4902d on 11.x
    Issue #3447206 by pdureau: Add pdureau as a co-maintainer for the Theme...
nod_’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Welcome to the maintainer team!

Committed and pushed 6eb4902d0d to 11.x and 07e25d6994 to 11.0.x and 7295751bb9 to 10.4.x and c87b28be5a to 10.3.x. Thanks!

wim leers’s picture

Welcome! 😄 (And thank you 😊)

pdureau’s picture

Thanks everybody 💐

xjm credited bnjmnm.

xjm credited larowlan.

xjm credited lauriii.

xjm credited longwave.

xjm’s picture

Adding missing credits for maintainers who discussed and approved the appointment.

larowlan’s picture

Removing my credit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.