Problem/Motivation
Pierre Dureau has been doing great work in supporting the Single Directory Components initiative.
His expertise in building design system implementations, and his work on discussing and shaping Single Directory Components make him an ideal candidate for maintaining it now that it's part of the Theme API.
The proposal is to add Pierre to the Theme API maintainers, but have his responsibilities focused on Single Directory Components.
He indicated he is interested in this.
Steps to reproduce
Proposed resolution
- Discuss.
- Approval from committers.
- Patch, review, commit.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comments
Comment #2
e0ipsoPierre, like I already told you, thanks for being part of this community, and for putting up with me 😜
Comment #3
mherchel+1 on adding @pdureau as maintainer. His help during development was invaluable.
He is not the only one that should be added IMHO, cross linking #3447487: Add e0ipso as a co-maintainer of core theme system with focus on SDC
Comment #4
nod_Very much +1
Comment #5
ckrinaHuge +1. Beyond other qualities, his willingness to coordinate with others make him a great maintainer.
Comment #6
xjmSounds like a great fit!
To commit this, we need @pdureau to confirm reading the Drupal core governance, and agreeing to the responsibilities listed under:
(Plus an MR to add him to MAINTAINERS.txt.)
Thanks everyone!
Comment #7
xjmComment #8
oldebBig +1 !
Comment #9
grimreaperHi,
+1 on this too.
Working since 5 years with Pierre on UI Suite and following him on his other projects like https://dilla.io/, I can't count the architecture discussions we have on Drupal rendering system, UI Suite and new technological ideas.
Comment #10
sharique commentedBig +1 from me also.
Comment #11
finnsky commented+1
Thank you!
Comment #12
gaydabura commented+1
Comment #13
vmoskalenko commentedAbsolutely agree ! For more than 5 years of working with Pierre, he daily shows great professionalism in architectural solutions, both in the integration of UI Suite and in general.
Comment #14
pdureau commentedHello all, thanks for all the love ♡♡♡
Hi @xjm, I have read the 3 chapters of drupal-core.md and I agree with them.
If I will have the honour of joining the maintainer team of Drupal\Core\Theme sub-system, I will come with my skills and my passion, and also some proposals I wish to discuss with the team:
Cheers,
Comment #15
g4mbiniWhat a huge and great news ! You deserve it so much Pierre and I'm sur you'll do a great job !
++++++++1
Comment #16
nicxvan commentedThis is exciting!
Comment #17
mherchelComment #14 is getting me all excited! 😅😍😆
Comment #18
celdia commented+1
He deserves it, Pierre !
Comment #19
eme commented+1 of course !
Comment #20
just_like_good_vibesbig +1
thanks for being part of the community
and what you do
Comment #22
ckrinaComment #23
ckrinaActually as per #14 I think this can be moved as RTBC to be committed.
Comment #29
nod_Welcome to the maintainer team!
Committed and pushed 6eb4902d0d to 11.x and 07e25d6994 to 11.0.x and 7295751bb9 to 10.4.x and c87b28be5a to 10.3.x. Thanks!
Comment #30
wim leersWelcome! 😄 (And thank you 😊)
Comment #31
pdureau commentedThanks everybody 💐
Comment #36
xjmAdding missing credits for maintainers who discussed and approved the appointment.
Comment #37
larowlanRemoving my credit