Problem/Motivation

Secondary tabs design is distorted on block view page

Steps to reproduce

1. Visit /admin/structure/views/view/articles_aside page.
2. You will notice the secondary tabs design is distoreted.
3. See screenshot for reference.
4. view-ui.css file is missing on block view page.

Block's view page (without view-ui.css file)

Proposed resolution

Add views-ui.css file to views_ui/admin.styling.

Remaining tasks

User interface changes

After Patch

API changes

NA

Data model changes

NA

Release notes snippet

NA

CommentFileSizeAuthor
#11 Screenshot 2024-07-02 at 8.49.09 AM.png54.23 KBgauravvvv

Issue fork drupal-3444998

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Related issues: +#3436936: Claro should use libraries-extend for views_ui.css

This is a regression bug of #3436936: Claro should use libraries-extend for views_ui.css

Gauravvvv opened merge request !7895

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed (maintainer needs more info)

articles_aside isn't a core view but I want to another view block page and am not seeing the issue.

Was on 11.x standard install.

lolgm’s picture

lolgm commented
Related issues: +#3457768: Views "display menu tabs" styling breaks when adding an "Entity Reference" display, +#3443998: [regression] missing css file in views ui admin UI

Steps to reproduce

  1. Do a standard installation of Drupal (10.3.0 || 11.x-dev)
  2. Create a new view for the nodes and enable the default block.
  3. Edit the view you just created.
  4. Add a contextual filter on the display Block (block_1) of "Content: ID"
  5. While configurating the contextual filter, activate the option "When the filter value is NOT available" -> "Provide default value" and select the type "Content ID from URL"
  6. Save the contextual filter changes.
  7. Save the view and reload the page.
  8. Has you can see the display tabs have been deformatted.

As far as I tested, this happens whenever "Provide default value" is used in the contextual filter of a block.

I believe this problem is also related to:
#3457768: Views "display menu tabs" styling breaks when adding an "Entity Reference" display
#3443998: [regression] missing css file in views ui admin UI

lolgm’s picture

lolgm commented
Status: Postponed (maintainer needs more info) » Active
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Needs work

In #3436936: Claro should use libraries-extend for views_ui.css we removed the views-ui.css file from the global stying but mistakenly added the file to the views/views.module when it should have been views_ui/admin.styling.

TravisCarden made their first commit to this issue’s fork.

traviscarden’s picture

traviscarden commented
Status: Needs work » Needs review

^^ Like so, @nod_?

gauravvvv’s picture

gauravvvv commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2024-07-02 at 8.49.09 AM.png54.23 KB

MR !7895, fixed the issue. Added after MR screenshot for reference.

lolgm’s picture

lolgm commented

The problem I reported in #6 was also resolved by MR !7895.

  • nod_ committed 9f145101 on 10.3.x 
    Issue #3444998 by Gauravvvv, TravisCarden, lolgm, nod_, smustgrave:...

  • nod_ committed 7beacd4a on 10.4.x 
    Issue #3444998 by Gauravvvv, TravisCarden, lolgm, nod_, smustgrave:...

  • nod_ committed 9a8588df on 11.0.x 
    Issue #3444998 by Gauravvvv, TravisCarden, lolgm, nod_, smustgrave:...

  • nod_ committed c3383f44 on 11.x 
    Issue #3444998 by Gauravvvv, TravisCarden, lolgm, nod_, smustgrave:...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Perfect, thanks!

Committed and pushed c3383f44d5 to 11.x and 9a8588df4b to 11.0.x and 7beacd4a87 to 10.4.x and 9f14510102 to 10.3.x. Thanks!

nod_ closed merge request !7895

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.