Problem/Motivation

- goto navigation's layout block builder. toggle 'narrow' sidebar mode. notice 'show content preview' can not be clicked unless at new letters 'view'

Steps to reproduce

also see: https://www.drupal.org/files/issues/2024-05-01/sidebar-noclick_zone.mov

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#19 Edit layout for Navigation layout _ drupal11OS (2).mp41.22 MBahsannazir
#18 Screen Recording 2024-05-16 at 6.46.26 AM.mov7.81 MBskaught
#17 Navigation layout _ D11.mp4358.07 KBkanchan bhogade
#16 Edit layout for Navigation layout _ drupal11OS (1).gif593.83 KBahsannazir
#15 navigation-no-norrow.mov3.41 MBskaught
#11 AfterMR-8038.mp4308.45 KBkanchan bhogade
#11 BeforeMR-8038.mp4325.41 KBkanchan bhogade
#10 Edit layout for Navigation layout _ drupal11OS.gif234.78 KBahsannazir
sidebar-noclick_zone.mov5.8 MBskaught
click-deadzone.png119.64 KBskaught

Issue fork drupal-3444699

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

SKAUGHT created an issue. See original summary.

skaught’s picture

skaught
Primary language English
commented
Issue summary: View changes
skaught’s picture

skaught
Primary language English
commented
Title: Navigation LayoutBuilder UIhas click dead zone » Navigation LayoutBuilder UI has dead click zone
skaught’s picture

skaught
Primary language English
commented
Related issues: +#3444602: Navigations 'expand sidebar' on Layout Builder UI is in wrong location.

maybe both these are related to offset use.

Gauravvvv made their first commit to this issue’s fork.

Gauravvvv opened merge request !8038

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
finnsky’s picture

finnsky commented
Status: Needs review » Needs work

This fix breaks collapsed sidebar expand popover functional.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Thank you for the feedback @finnsky, I have updated the MR with different approach.

ahsannazir’s picture

ahsannazir commented
StatusFileSize
new Edit layout for Navigation layout _ drupal11OS.gif234.78 KB

The changes are working fine. Attaching screen capture

kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new BeforeMR-8038.mp4325.41 KB
new AfterMR-8038.mp4308.45 KB

Hi
I've tested MR!8038 on Drupal 11.x
MR is applied cleanly...

On the Navigation LayoutBuilder, Link is added and it's working.

Adding Screen recording for reference

RTBC+1

Keeping in "Needs review" for code verification

finnsky changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to hidden.

finnsky changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to active.

finnsky’s picture

finnsky commented

Looking good to me +1 rtbc. I've added 2 small improvements.

1. Added type=submit to expand/close buttons to avoid LB form submit.
2. Added minor css fixes. Font size for LB text and always wide sidebar in css.

skaught’s picture

skaught
Primary language English
commented
Status: Needs review » Needs work
StatusFileSize
new navigation-no-norrow.mov3.41 MB

The lower 'narrow/expand' button is now locked open if user click. the left side of the page content remains fixed left (remains partially hidden under the entire nav.

ahsannazir’s picture

ahsannazir commented
Status: Needs work » Needs review
StatusFileSize
new Edit layout for Navigation layout _ drupal11OS (1).gif593.83 KB

Made changes to the MR. Attached screen capture for ref.

kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new Navigation layout _ D11.mp4358.07 KB

Hi
I've tested MR!8038 on Drupal 11.x
MR is applied cleanly...

Left sidebar button is clickable and Content page hiding issue fixed
Adding Screen recording for reference

RTBC+1

Keeping in "Needs review" for code verification

skaught’s picture

skaught
Primary language English
commented
Status: Needs review » Needs work
StatusFileSize
new Screen Recording 2024-05-16 at 6.46.26 AM.mov7.81 MB

Steps forward!
I'm still finding some general switching it from narrow and back and forth again the overhanging is reoccurring.

ahsannazir’s picture

ahsannazir commented
StatusFileSize
new Edit layout for Navigation layout _ drupal11OS (2).mp41.22 MB

I restested to see the issue mentioned in #18 but was not able to reproduce the same. Attaching screen capture for reference

skaught’s picture

skaught
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

@ahsannazir thanks!
I have also retested this morning and can not recreate what I had seen. I think I had a local cache problem from branch changes. I'll move to RTBC.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Needs work

Thanks for the fix, let's keep the scope to what the issue is about though.

Can you roll back the button and font size fixes and create new issues? The git history will be useless if we sneak in out of scope fixes.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Needs work

thx, minor whitespace to fix and we should be good to go

Gauravvvv changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to hidden.

Gauravvvv changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to active.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Whitefix has been added, This is ready to go

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

all good now

nod_ closed merge request !8038

  • nod_ committed 2aa3efe0 on 10.3.x 
    Issue #3444699 by Gauravvvv, finnsky, ahsannazir, nod_, SKAUGHT, Kanchan...

  • nod_ committed 83e91f4d on 10.4.x 
    Issue #3444699 by Gauravvvv, finnsky, ahsannazir, nod_, SKAUGHT, Kanchan...

  • nod_ committed 43e4c0c9 on 11.0.x 
    Issue #3444699 by Gauravvvv, finnsky, ahsannazir, nod_, SKAUGHT, Kanchan...

  • nod_ committed d4883273 on 11.x 
    Issue #3444699 by Gauravvvv, finnsky, ahsannazir, nod_, SKAUGHT, Kanchan...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d488327312 to 11.x and 43e4c0c9c6 to 11.0.x and 83e91f4dcb to 10.4.x and 2aa3efe0d9 to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.