Problem/Motivation

In /core/misc/ajax.js, response.asterisk is defined as boolean type but actual type is string.

Ref: Drupal\Core\Ajax\ChangedCommand document

Proposed resolution

Change response.asterisk type to string.

Remaining tasks

User interface changes

No

API changes

No

Data model changes

No

Release notes snippet

Issue fork drupal-3441782

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Tom Konda created an issue. See original summary.

dineshkumarbollu made their first commit to this issue’s fork.

dineshkumarbollu opened merge request !7599

dineshkumarbollu’s picture

dineshkumarbollu commented

Reference document for type string https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Ajax%21Ch...

tom konda’s picture

tom konda
Primary language Japanese
Location Kanagawa, Japan
commented
Status: Active » Needs review

I think this MR looks good.
Please review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward.

  • nod_ committed fec39628 on 11.x 
    Issue #3441782 by dineshkumarbollu, Tom Konda: JSDoc for ajax command "...

nod_ closed merge request !7599

nod_’s picture

nod_
Primary language French
Location Lille
commented
Category: Bug report » Task
Status: Reviewed & tested by the community » Fixed

Minor so no backport

Committed fec3962 and pushed to 11.x. Thanks!

  • nod_ committed fec39628 on 11.0.x 
    Issue #3441782 by dineshkumarbollu, Tom Konda: JSDoc for ajax command "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.