If I try to create a test website on simplytest.me, adding the Navigation module causes the attempt to fail upon submit with an error message.

Steps:

  1. Go to https://simplytest.me
  2. In the Evaluate Drupal projects field, type "core" (without the quotes)
  3. Click Advanced options
  4. In the Additional project name field, type navigation
  5. Choose the "Navigation" project from the list of projects
  6. Click Launch sandbox

Expected result: simplytest.me generates a sandbox including the Navigation module
Actual result: simplytest.me returns two error messages:

additionalProjects.0.shortname: This value should not be blank.
additionalProjects.0.version: This value should not be blank.

Screen print of simplytest.me sandbox request screen showing the result of the steps above as described in text

As a control, I tried the same procedure using Admin Toolbar (admin_toolbar) in place of Navigation as an added module. The error did not occur.

Comments

Charles Belov created an issue. See original summary.

charles belov’s picture

Title: Navigation module not playing well with simplytest.me » Navigation module gets error when added on simplytest.me
skaught’s picture

Priority: Normal » Minor
Related issues: +#3439747: [No commit] Prepare for core inclusion

I might assume that because this module (only having a dev line) and is being prepared for core inclusion that flaws in the current .info.yml are there for this purpose.

charles belov’s picture

That's unfortunate. I wanted to check whether there were any conflicts between the Navigation and Admin Toolbar modules.

It might be good to temporarily fix the .yml file to work with simplytest.me then revert when it's ready to go into core.

Or is there a Navigation-inclusive version of core I need to use with simplytest.me?

skaught’s picture

yes, once in core it will be 'a beta' module. toolbar will still be there and active, until you choose to enable Navigation.
When Navigation is stable in (i myself assume) Toolbar would be fully removed, and then default in Standard Profile.

I can tell you myself: simply, these 2 modules (admin_toolbar) would not be compatible.

^btw: A key new feature in Navigation is a plugin that allows sitebuidlers to 'add other menu blocks'. [this will help supercede some other contrib modules too]

The goal of Navigation is to 100% toolbar, and currently does force the removal of 'toolbar' (the toolbar element) from 'page top'. there's not plan to align with admin_toolbars JS...etc In the background, Toolbar is still running if enabled, again Navigation bypasses final render.

Keeping in mind, Admin Toolbar's key feature is it's 3/4 level drop downs on top of Toolbars 1/2.. Navigation is this but side attached (:

skaught’s picture

StatusFileSize
new73.78 KB

PS: TUGBOAT - "the new thing"
You should also look into Tugboat access through your d-org account!

skaught’s picture

StatusFileSize
new134.4 KB


to validate that with both modules on: we see no Admin Toolbar. there are also no JS console errors -- everything looks clean.

charles belov’s picture

Okay, I don't want to mess up your Tugboat instance. The instance on #3441615: navigation_theme() loads 'extension.list.module' for no purpose. doesn't seem to have Admin Toolbar.

However, the specific configuration I want to test is as follows:

  1. On /admin/modules, in addition to the Admin Tool bar, enable Admin Toolbar Extra Tools
  2. Click Install
  3. Expand Admin Toolbar Extra Tools
  4. Click Configure
  5. Check Enable/Disable local tasks display
  6. Click Save configuration
  7. Navigate to some existing content

Expected result: there is a local task menu, with the following sub-items:

  • View
  • Edit
  • Delete
  • Revisions

Presumably with Navigation also installed, the local task menu would be incorporated into the left side bar navigation.

If Admin Tool Bar isn't compatible with navigation, then I would expect there to be some other means by which I could incorporate such a menu and sub-menu into the navigation menu.

As a sidenote, I dislike the "local task" label as being jargon, and have separately filed #3436899: Improve 'Local Tasks' menu label

charles belov’s picture

skaught’s picture

@Charles Belov. Welcome!
I understand the flood of concerns when discovering this work! i've only gotten involved in the last few weeks myself.

I posted this on 3441903 as well: this will help find the 'current plan' for Navigation!
https://www.drupal.org/project/issues/navigation?text=%5Bplan%5D&status=...

On Drupal Slack you'll be able to the 'Admin UI' channel -- this is where the Navigation Project/team is to be found. weekly meetings are Wednesdays (timezones) if you want to get involved this way!

---

Sorry that simplytest.me is blocking for you this way!

ckrina’s picture

We've been in contact with the Admin Toolbar folks in the past so they can expand and implement functionalities on the Navigation and coordinate on that, but we haven't had time to sync again after the Beta release just last week. Since Admin Toolbar works on top of the old Toolbar, don't expect its features on the new navigation yet. We (navigation team) will help as much as we can but the updates the Admin Toolbar module will need will be important, so please be aware that it won't be a matter of a few days. :)

The initial conversations were promising and features like the Devel menu or the Search were a few of the ones Admin Toolbar could possibly add a lot of value. We're also Drupal devs that use Admin Toolbar on every project, so it's in our own interest to coordinate to work together, but we're just focused on getting this in core in the next days.

It might be good to temporarily fix the .yml file to work with simplytest.me then revert when it's ready to go into core.

We're focused on getting the feedback addressed in the next week and adding this extra step will add work on the MR update process. The deadline to get into 10.3 is the week of 29th April, so this will be fixed in a week max either way.

ckrina’s picture

Project: Navigation » Drupal core
Version: 1.x-dev » 11.x-dev
Component: Code » navigation.module
skaught’s picture

Status: Active » Closed (works as designed)

Navigation has been accepted to Drupal 11 dev line now. I'll close this as is no longer valid. thanks!