Problem/Motivation

Follow up from #3296098: Removal :tabbable usage in dialog.js from @catch

figure out what to do with dialogClass

This was deprecated in jQuery UI, but was still in use in various places in core.

The original issue added a PHP deprecation to 10.3, but not a JavaScript deprecation, we should try to add a js deprecation to 10.3.x

Steps to reproduce

N/A

Proposed resolution

Trigger deprecation in core/misc/dialog/dialog.js

Remaining tasks

Decide what to do
Implement it
Review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3440676

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented
Title: Figure out what to do with dialogClass » Trigger a JavaScript deprecation error for dialogClass in forked dialog.js

Re-titling - I figured out the PHP deprecation layer in the other issue, so now this issue is just about whether we want to add a js deprecation too, which seems fine if we can, but also non-critical.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

I lost more time than I'd care to admit on a Project Browser issue due to there not being a JS deprecation, so I'm a big +1 on having this done to spare other 10 > 11 upgraders that annoyance.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes

Updating the issue summary.

Utkarsh_33 made their first commit to this issue’s fork.

Utkarsh_33 opened merge request !8227

utkarsh_33’s picture

utkarsh_33 commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Cleaned up issue summary some.

Updated deprecation for 10.4 since 10.3.0 is now out. But deprecation seems fine.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Needs work
smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Done

nod_ closed merge request !8227

  • nod_ committed ec9ed869 on 10.4.x 
    Issue #3440676 by Utkarsh_33, smustgrave, catch, bnjmnm, nod_: Trigger a...

  • nod_ committed 71230ba4 on 11.0.x 
    Issue #3440676 by Utkarsh_33, smustgrave, catch, bnjmnm, nod_: Trigger a...

  • nod_ committed eeaf9c82 on 11.x 
    Issue #3440676 by Utkarsh_33, smustgrave, catch, bnjmnm, nod_: Trigger a...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

Added this issue to the CR: https://www.drupal.org/node/3440844

Committed and pushed eeaf9c829e to 11.x and 71230ba40a to 11.0.x and ec9ed86905 to 10.4.x. Thanks!

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Fixed » Needs work

Had to revert on 10.4.x as there are test failures due to the code still using dialogClass somewhere.

  • nod_ committed 0589524c on 10.4.x 
    Revert "Issue #3440676 by Utkarsh_33, smustgrave, catch, bnjmnm, nod_:...
nod_’s picture

nod_
Primary language French
Location Lille
commented 
    Remaining self deprecation notices (5)
    
      5x: Javascript Deprecation: dialogClass is deprecated in drupal:10.4.x
    and will be removed from drupal:12.0.0.
        4x in MediaLibraryTest::testAllowedMediaTypes from
    Drupal\Tests\ckeditor5\FunctionalJavascript
        1x in MediaLibraryTest::testAlt from
    Drupal\Tests\ckeditor5\FunctionalJavascript
quietone’s picture

quietone commented
Version: 10.4.x-dev » 10.6.x-dev
quietone’s picture

quietone commented
Title: Trigger a JavaScript deprecation error for dialogClass in forked dialog.js » [backport] Trigger a JavaScript deprecation error for dialogClass in forked dialog.js
quietone’s picture

quietone commented
Version: 10.6.x-dev » 11.0.x-dev
Status: Needs work » Fixed

I was wondering if this makes sense to do the backport now, so late in the Drupal 10 cycle. There is still the PHP deprecation in D10 and D11 has the JS deprecation notice. Catch agrees with not backporting this, so I am restoring the fixed status.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.