Background

On menu child items, the padding around each button needs to be 12px top/bottom and 16px left/right
On the current Drupal Admin UI Tugboat site, it’s showing 10px top/bottom and 16px left and 12px right

Steps to Reproduce

Click on a menu item that has a child item item. Inspect padding on child item with dev tools

Acceptance Criteria

Padding has been updated on child items to be 12px top/bottom and 16px left/right

Links

Link to Figma Design: https://www.figma.com/file/VCPAxetieAC2pzw7hgX3ij/Drupal-Admin-UI---Design-System?type=design&node-id=667%3A18270&mode=dev

Screenshots

What it looks like in dev
image of padding of child items on dev

What it looks like in the design

image of what the child menu looks like in design

CommentFileSizeAuthor
#7 Screenshot from 2024-05-01 23-07-56.png364.63 KBadwivedi008
child-menu-items-design.png25.72 KBjwitkowski79
child-menu-items-onDev.png71.36 KBjwitkowski79

Issue fork drupal-3440223

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jwitkowski79 created an issue. See original summary.

bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented

I think this issue has been fixed by #3440228. Is that right @jwitkowski79?

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Project: Navigation » Drupal core
Version: 1.x-dev » 11.x-dev
Component: Code » navigation.module
Issue tags: +Novice

I can confirm the new styles haven't been updated yet, so leaving this as active.

bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented
Assigned: Unassigned » bronzehedwick

bronzehedwick opened merge request !7857

bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented
Assigned: bronzehedwick » Unassigned
Status: Active » Needs review
adwivedi008’s picture

adwivedi008 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2024-05-01 23-07-56.png364.63 KB

Verified the changes mentioned on MR-7857
The padding is 12px 16px over the menu items child

Attaching a screenshot as a reference

Moving the issue to RTBC

RTBC++

nod_’s picture

nod_
Primary language French
Location Lille
commented

can I get a rebase/merge of 11.x here please? I know the merge request works but it doesn't apply cleanly as a patch.

ahsannazir made their first commit to this issue’s fork.

  • nod_ committed 525ec2bc on 10.3.x 
    Issue #3440223 by bronzehedwick, ahsannazir, jwitkowski79, adwivedi008:...

  • nod_ committed 3ce91cc4 on 10.4.x 
    Issue #3440223 by bronzehedwick, ahsannazir, jwitkowski79, adwivedi008:...

nod_ closed merge request !7857

  • nod_ committed 81c4fd68 on 11.0.x 
    Issue #3440223 by bronzehedwick, ahsannazir, jwitkowski79, adwivedi008:...

  • nod_ committed 91b4cf23 on 11.x 
    Issue #3440223 by bronzehedwick, ahsannazir, jwitkowski79, adwivedi008:...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 91b4cf2 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.