Background

When the Sub Menu is expanded, there should be no radius on the bottom of the button on hover/focus state.

Steps to Reproduce

Click on the sub menu to see the hover / focused state.

Acceptance Criteria

There should be no bottom radius on the expanded sub menu.

Screenshots

How Drupal UI currently looks like in dev
image of submenu focus in dev

How Drupal UI currently looks like in design
image of submenu with hover as designed

CommentFileSizeAuthor
#7 Снимок экрана 2024-04-29 в 17.26.22.png22.64 KBkostyashupenko
#7 Снимок экрана 2024-04-29 в 17.26.29.png22.26 KBkostyashupenko
#7 Снимок экрана 2024-04-29 в 17.26.35.png16.83 KBkostyashupenko
#7 Снимок экрана 2024-04-29 в 17.26.42.png17.58 KBkostyashupenko
submenu_hover_design.png29.72 KBjwitkowski79
submenu_focus_onDev.png15.81 KBjwitkowski79

Issue fork drupal-3440220

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jwitkowski79 created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Project: Navigation » Drupal core
Version: 1.x-dev » 11.x-dev
Component: Code » navigation.module

shwetaDevkate made their first commit to this issue’s fork.

adelansari made their first commit to this issue’s fork.

adelansari opened merge request !7797

kostyashupenko made their first commit to this issue’s fork.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new Снимок экрана 2024-04-29 в 17.26.42.png17.58 KB
new Снимок экрана 2024-04-29 в 17.26.35.png16.83 KB
new Снимок экрана 2024-04-29 в 17.26.29.png22.26 KB
new Снимок экрана 2024-04-29 в 17.26.22.png22.64 KB

Resolved CSS linting issues. Just by running `yarn lint:css --fix`.

Issue seems fixed. Here are 4 screens illustration outline rings for hover and focus states, for both collapsed and expanded states.

Test

Test

Test

Test

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 9665396 and pushed to 11.x. Thanks!

nod_ closed merge request !7797

nod_’s picture

nod_
Primary language French
Location Lille
commented

  • nod_ committed 96653961 on 11.x 
    Issue #3440220 by kostyashupenko, adelansari: Remove bottom radius on...

  • catch committed 051b9bae on 10.3.x authored by nod_ 
    Issue #3440220 by kostyashupenko, adelansari: Remove bottom radius on...
catch’s picture

catch
he/him
Primary language English
commented
Status: Patch (to be ported) » Fixed

  • nod_ committed 96653961 on 11.0.x 
    Issue #3440220 by kostyashupenko, adelansari: Remove bottom radius on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.