Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
user system
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Apr 2024 at 22:17 UTC
Updated:
12 Apr 2024 at 16:18 UTC
Jump to comment: Most recent
Comments
Comment #3
poker10 commentedCreated an initial attempt for this in the MR.
The change I made is simple:
For the flood limits, I used the existing variables:
user_failed_login_user_windowuser_failed_login_user_limitSo this means we allow 5 failed current password validations every 6 hours. Not sure if this number is too low, but if yes, we can create new variables and make this limit bigger.
I have also added a test for this, which is testing user edit form and current password validations with and without entering the current password, to see, if flood control was triggered.
Here is a test only job, where one test failed as expected: https://git.drupalcode.org/project/drupal/-/jobs/1313301 (the second test does not failed, because it is testing the empty current password which is not supposed to trigger the new flood control)
The regular pipeline is green (for each PHP/SQL combination): https://git.drupalcode.org/project/drupal/-/pipelines/145034
Moving to Needs review.