In the Drupal core JavaScript, some of string comparison checks that starting with a specific text or ending with a specific text. I think these comparisons are suitable to use String.prototype.startsWith() or String.prototype.endsWith().
Ref: https://github.com/typescript-eslint/typescript-eslint/issues/285
Use String.prototype.startsWith() or String.prototype.endsWith().
https://git.drupalcode.org/project/drupal/-/merge_requests/7411
No.
No.
No.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3439646-nr-bot.txt | 90 bytes | needs-review-queue-bot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !7411
Comments
Comment #3
tom kondaSome of PHPUnit Functional Javascript tests and Nightwatch tests are failed.
Need to resolve failed tests.
Comment #4
nod_is there an associated eslint rule to enforce this?
Comment #5
nod_tests are green, changes looks good
Comment #6
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #7
tom konda@nod_ No, I think no rule is found in ESLint plugins for vanilla JavaScript at this point.
"typescript-eslint" plugin has ESLint rule but this rule is for TypeScript.
Comment #9
sakthi_dev commentedRebased with the latest changes in 11.x. Please review.
Comment #10
tom konda@sakthi_dev After commit id 135e3ba1 original script size is changed, so need to recalculate script size.
Comment #11
tom kondaAll tests are passed. Please review.
Comment #12
tom kondaMR has conflict because of testing file changing at commit 05e4d1a8. Need to resolve this conflict.
Comment #13
tom kondaMerge test file changing at commit 05e4d1a8 to the MR and all tests are passed.
Please review.
Comment #14
smustgrave commentedLeft some comments on the MR.
Comment #15
tom kondaComment #16
smustgrave commentedFeedback appears to be addressed
Comment #22
nod_Committed and pushed f5cc65456a to 11.x and cc355625ad to 11.0.x and 05b6144bd0 to 10.4.x and 270f95ac48 to 10.3.x. Thanks!
Comment #23
smustgrave commentedCan't tell but this one may be causing random failures on 11.x