Closed (fixed)
Project:
Drupal core
Version:
10.3.x-dev
Component:
navigation.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Apr 2024 at 11:44 UTC
Updated:
24 Sep 2024 at 16:09 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
ckrinaPlease be aware of #3405006: The footer shadow disappears when a button is hovered because maybe the work here can close that other issue.
Comment #3
ckrinaComment #4
ckrinaComment #7
skyriter commentedI added this merge request during the Portland DrupalCon 2024 Contribution day.
Comment #8
skyriter commentedCould someone take a look at this when they have a moment?
Comment #9
scottatdrake commentedI am not a front end expert but I imagine the values for -webkit-box-shadow and filter should be consistent. In the original CSS, the filter uses pixel values (px), but the added -webkit-box-shadow uses rem units.
Comment #10
gauravvvv commentedYou can directly use box-shadow.
As box shadow is supported in safari browser, there is no need of using
-webkit-box-shadowAlso, for consistency use px units over rem here. thanks
Comment #11
skyriter commented@marky was mentoring at my table and helped me in my first time contribution.
Comment #12
skyriter commentedUPDATE: I just read the comment by @gauravvvv, who said the same thing yesterday. Thank you.
I'm continuing with this work. Whereas yesterday, I added a -webkit-drop-shadow to maintain Safari UI parity with Chrome and Firefox, I realized that the type of shape we are putting the shadow on was a rectangle and should be visually identical with box-shadow, which Safari supports. So I'm going to update the code accordingly.
Comment #13
skyriter commentedCompared in a visual diff tool both the Safari and Chrome output, and it was the same.
Comment #14
mradcliffeI updated the issue summary to add the proposed resolution that @skyriter mentioned in #12.
Comment #15
mradcliffeI embedded the gif in the issue summary as well.
Comment #16
mradcliffeWe should also add the steps to reproduce to the issue summary rather than in the merge request comment, @skyriter.
Comment #17
skyriter commentedThank you for all your help, @mradcliffe. Those steps are now here in this issue. This should be ready once more to be reviewed.
Comment #18
ahsannazir commentedThe changes look fine and are working as expected on safari as well.
Comment #19
smustgrave commentedBelieve this one has been tested and working fine in safari. Issue summary looks good also.
Comment #20
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #22
ahsannazir commentedComment #23
smustgrave commentedThere's already a branch for 11.x with an MR, don't think we need to start a new one.
Comment #25
ahsannazir commentedComment #26
smustgrave commentedThanks @omahane
Test failure is unrelated was fixed when #3208247: After deleting a translated article, search wants to reindex it was reverted.
Comment #28
nod_Committed and pushed 6fc1e6f2e9 to 11.x and 1f7b5b3b4c to 11.0.x and b17eca1c91 to 10.4.x and 590fb5278d to 10.3.x. Thanks!
Comment #29
nod_Comment #35
jacobupal commented