Problem/Motivation

Claro includes views_ui.css in its global styling library, but this should probably be in claro/views_ui then use libraries_extend to add it to views_ui.admin - this would save it being loaded on pages it's never going to be used.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3436936

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 11.x Comparecompare
    • 1 hidden branch
  • 3436936-11.x Comparechanges, plain diff MR !7307
About issue forks

Comments

catch created an issue. See original summary.

SandeepMahlawat made their first commit to this issue’s fork.

SandeepMahlawat opened merge request !7307

sandeepmahlawat’s picture

sandeepmahlawat commented
Status: Active » Needs review

I have provided a patch for the same. please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Still appears to be loading globally.

Aman_Goel’s picture

Aman_Goel commented
Assigned: Unassigned » Aman_Goel

Gauravvvv made their first commit to this issue’s fork.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

I have addressed the feedback on MR, and updated the MR for the same.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks @Gauravvv think this is good now.

  • nod_ committed 9069a0a9 on 11.x 
    Issue #3436936 by SandeepMahlawat, Gauravvvv, smustgrave, catch: Claro...

  • nod_ committed 9e0c5a53 on 10.3.x 
    Issue #3436936 by SandeepMahlawat, Gauravvvv, smustgrave, catch: Claro...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Assigned: Aman_Goel » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed 9069a0a and pushed to 11.x. Thanks!

nod_ closed merge request !7307

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.