Problem/Motivation

In and edge case a list of links using the nav-tabs element could be placed inside a form. The button element has a default event to submit a form and we don't want opening the tabs-list to do that.

Steps to reproduce

Place a nav-tabs element inside a from. In collapsed state click the display toggle button for the nav-tabs. This will trigger submit.

Proposed resolution

A button of type=button doesn't have a default even. This is a simple solution and shouldn't do any harm even if it only fixes edge cases.

Issue fork drupal-3436761

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

simohell created an issue. See original summary.

simohell opened merge request !7230

simohell’s picture

simohell commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward and makes sense.

  • nod_ committed 86a3216b on 10.3.x 
    Issue #3436761 by simohell: Remove default event from collpased nav-tabs...

  • nod_ committed ca84e6d5 on 10.2.x 
    Issue #3436761 by simohell: Remove default event from collpased nav-tabs...

nod_ closed merge request !7230

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 5614128 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.