Problem/Motivation

Following #3109556: Update from Yarn 1 to Yarn 4 commit-code-check.sh is broken for the spellcheck component.

Steps to reproduce

Add a spelling error to code and run core/scripts/dev/commit-code-check.sh, output is incorrect:

1/1 stdin:// 292.98ms
CSpell: Files checked: 1, Issues found: 0 in 0 files

Proposed resolution

Fix the call to yarn spellcheck.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3432249

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !7097

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

MR fixes this and reverts the line to closer what it was before, with the removal of the -s switch which is no longer supported (Yarn 4 is silent by default).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks great

  • nod_ committed ad704a35 on 11.x 
    Issue #3432249 by longwave, alexpott: cspell check is broken in commit-...

nod_ closed merge request !7097

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Fixed

hopefully that'll fix the needs review bot too

Committed ad704a3 and pushed to 11.x. Thanks!

nod_’s picture

nod_
Primary language French
Location Lille
commented

looks like it did the trick

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.