Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\views\Annotation\ViewsJoinplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3426958

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

godotislate made their first commit to this issue’s fork.

sorlov made their first commit to this issue’s fork.

sorlov opened merge request !7051

sorlov’s picture

sorlov commented
Status: Active » Needs work
sorlov’s picture

sorlov commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

MR appears to have a failure.

sorlov’s picture

sorlov commented
Status: Needs work » Needs review
mstrelan’s picture

mstrelan commented
Status: Needs review » Needs work

Same suggestions as #3426961-10: Convert ViewsSort plugin discovery to attributes

sorlov’s picture

sorlov commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Searched the repo for @ViewsJoin and all 5 instances have been replaced

Also, let's update the description in \Drupal\views\Plugin\views\sort\SortPluginBase to mention attributes instead of annotations.

But for this ticket version, seems to have been addressed

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed ff659267d9 to 11.x and 68f39ef12c to 10.3.x. Thanks!

  • alexpott committed 68f39ef1 on 10.3.x 
    Issue #3426958 by sorlov, godotislate, mstrelan, smustgrave: Convert...

  • alexpott committed ff659267 on 11.x 
    Issue #3426958 by sorlov, godotislate, mstrelan, smustgrave: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.