Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
asset library system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Jan 2024 at 15:37 UTC
Updated:
2 Feb 2024 at 12:29 UTC
Jump to comment: Most recent
Comments
Comment #3
alexpottComment #4
wim leersI can't find anything to complain about 🤓
Comment #5
smustgrave commentedQuestion, is this a feature we should add test coverage for?
Comment #6
alexpott@smustgrave I've added a test - it's not hard to add something small to a unit test for this.
Comment #7
wim leersOne nit on the MR.
Should we do some profiling or benchmarking here? 🤔 I think it's not really necessary because this only happens in the cold cache scenario, per:
… but it sure wouldn't hurt. We don't want to make the cold cache scenario more expensive/slower. But if anything, this should make it faster/cheaper.
Comment #8
alexpottFor the given code in test_script.php, Standard profile installed, on PHP 8.2 and APCu installed and enabled on CLI:
With MR using Symfony YAML
Without patch using Symfony YAML
Without patch and with PECL YAML installed
Comment #9
wim leersRandom failure in https://git.drupalcode.org/project/drupal/-/jobs/662217 because the MySQL DB went away, which made 4 unrelated kernel tests fail. I cannot retest this job 🤷♂️
#8 provides the numbers that remove any worries about cold cache scenarios 👍
Comment #11
catchCommitted/pushed to 11.x, thanks!