Problem/Motivation

In core/modules/ckeditor5/tests/src/FunctionalJavascript/StyleTest.php there are several assertions which are commented and marked with Uncomment this after https://github.com/ckeditor/ckeditor5/issues/11709 is fixed..

Since that GitHub issue is closed and was released in the 38.0.0 release, we can now uncommented those assertions and live happily ever after.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3366633

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3361800: Update CKEditor 5 to 38.0.0

Spokje opened merge request !4172

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This adds additional test coverage that is now green, rtbc.

  • catch committed c9053e9d on 10.1.x 
    Issue #3366633 by Spokje: Uncomment assertions in StyleTest related to...

  • catch committed d838d8c0 on 11.x 
    Issue #3366633 by Spokje: Uncomment assertions in StyleTest related to...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Spokje closed merge request !4172

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements

Yay, this fixes part of what I still would like to do in #3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.