The Drupal.displace() method adds CSS custom properties to root HTML element (see https://www.drupal.org/node/3275981).
When an off-canvas top dialog is created, it outputs the correct value for the custom CSS property --drupal-displace-offset-top, however it outputs an invalid value for the --drupal-displace-offset-right property (which should be zero or not set).
Note this can be tested by installing the "Dialog test" module in the D10 compatible fork of cd_tools from @bnjmn (https://github.com/bbenjamin/cd_tools)
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !8991
Comments
Comment #2
mherchelI wonder if this is more a bug with either cd_tools or something with the off-canvas. I'm seeing the
data-offset-rightattribute on the top dialog which is causing this.Comment #3
gábor hojtsyRaising to major, as this also makes the now stable Workspaces impossible to demonstrate with Umami as I just reproduced when trying to screenshot it. When I undid the bogus --drupal-displace-offset-right value, it looked fine with Umami.
Comment #5
nod_I never like the auto compute of offset, the issue is that an empty data-offset-right/left is added when the offcanvas is created. Whether it's on the side or on top of the page. Making sure only the relevant attribute is added based on the position solves the issue.
Comment #7
gábor hojtsyI tried this with both Umami and Workspaces and Umami and Settings tray and they both worked fine. The code looks like the correct solution but I am not an expert in this. Attached videos of how it works after the fix.
Comment #8
gábor hojtsyDid a more extensive code context review and this looks like indeed the right place and way to fix this.
Comment #13
nod_Committed and pushed 3401675c3f to 11.x and 9006cbedab to 11.0.x and 14e9234d42 to 10.4.x and 6caa8062d0 to 10.3.x. Thanks!