Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The current details stylesheet doesn't make use of PostCSS nesting, custom properties, etc.
We can refactor this to make the code more portable, modular, and readable.
Comment | File | Size | Author |
---|---|---|---|
#12 | Screenshot 2023-03-20 at 3.19.49 PM.png | 132.14 KB | smustgrave |
#12 | Screenshot 2023-03-20 at 3.19.44 PM.png | 102.23 KB | smustgrave |
#9 | 3312636-9.patch | 10.43 KB | Gauravvvv |
#8 | after.png | 18.1 KB | lauriii |
#4 | 3312636-4-reroll.patch | 10.62 KB | mherchel |
|
Comments
Comment #2
mherchelComment #3
mherchelComment #4
mherchelRe-roll within minor changes attached.
Minor changes
Comment #6
mherchelRandom test failures are no longer failing. This is ready for review.
Comment #7
ckrinaLGTM!
Comment #8
lauriiiWhy are we changing the transition?
This slightly changes the margin inside the details. I think this looks better with the value before the change because the elements inside the wrapper are aligned with the summary.
Comment #9
Gauravvvv CreditAttribution: Gauravvvv at Axelerant for Drupal India Association commentedAddressed #8, attached patch for same.
Comment #10
mherchelIs there an interdiff to see what changed?
Comment #11
Gauravvvv CreditAttribution: Gauravvvv at Axelerant for Drupal India Association commentedI tried applying patch #4, but I was getting an error. That's why didn't provided interdiff.
I have replaced
transition: background-color 0.2s;
withAlso, replaced
margin: calc(2 * var(--details-spacing-unit)) calc(1.5 * var(--details-spacing-unit));
withmargin: var(--sp1-5) var(--sp2);
in the patch.Comment #12
smustgrave CreditAttribution: smustgrave at Mobomo commentedTested out by enabling Olivero when creating content
When to node/add/page
The details section doesn't seem broken. Here's a few screenshots but let me know if there's another section to check.