Form element "checkboxes" with "required" fails validation if all selected options are disabled

Added some tests.

Would help if I uploaded the right patch.

Applied patch #8 on 9.5.x and it works fine.Attaching screen recordings for reference.

Patch #8 applied successfully on Drupal 9.5.x.

Steps to Reproduce:
1. Install the New Drupal Instance
2. Go to the Structure->content->article->manage fields
3. Mark the "Required fields" in the field_tags settings.
4. Go to the Structure->content->Article->manage form display
5. Change the widget settings of the Tags field Auto select to Radio Button/ checkboxes
6. Create one Article content.
7. Make the "Tag1" checkbox disabled in the Article edit form via custom hook:

function my_module_form_alter(&$form, FormStateInterface $form_state, $form_id) {
if($form_id !== 'node_article_edit_form') {
return;
}
$form['field_tags']['widget'][1]['#disabled'] = TRUE;
}
8. Then Try to edit the Article content. You can able to reproduce the issue.

Test results:
After adding the Patch can able to edit the Article content.

If you feel it works please review the code and move to RTBC

Tested the patch #8 with Drupal 9.5 and php 8.1

- The issue summary is clear and provides steps to reproduce
- The patch applies cleanly
- The tests pass and test only patch has been provided
- As tested in #11 the patch fixes the issue
- The code looks good to me

Marking as RTBC for now

The latest patch on the issue doesn't have the tests from #8 - we definitely should have them.

+++ b/core/modules/options/tests/src/Functional/OptionsWidgetsTest.php
@@ -257,6 +264,23 @@ public function testCheckBoxes() {
+    $this->submitForm([], 'Save');
+    $this->assertSession()->pageTextNotContains('Error message');

We should be testing for something positive. Rather than page not containing something. Like some text that appears when you do the save. We should also test the value of the field.

Updated test case and added them back.

Applied patch in #23 on d.5.x-dev successfully. Adding screen recording for reference

Thanks for working on this.

I have two concerns here

1. Why is Checkboxes being patched instead of Checkbox? I am ready to admit I do not fully understand what goes pear shaped here but Checkbox::processCheckbox has a comment "for checkboxes with #access=FALSE or #disabled=TRUE, the #value is #default_value" which seems rather relevant. Why does this not fire?
2. Why is the test on a field instead of something directly on forms?

After Applied patch #8 on 9.5.x and works fine.Attached screenshot.

@Charlie ChX Negyesi if you have a solution for using checkbox we can take a look!

And reason for the tests was to mimic the steps from the IS.

Hello.

I'm asking for the community's help again because I think there is a bug in drupal core with the form #state API.

Specifically, checkboxes and lists are not activated as required by form #state.

In the case of checkboxes, the requirement asterisk is not added, but required="required" and aria-required="true" attribute are added, but the checkboxes do not become required.

The same is with the lists except that the asterisk is added, but it is not required either.

I have a list, which I use with the checkbox/radio widget, which is the master.

And I also use the other slave list with the checkbox/radio widget, I have controlled the visibility and the requirement with form #state.

When I choose a value or checkbox from the master list the slave list becomes visible and should be and required.

And the requirement doesn't work, an visibility working well.

I read a lot about this bug, since the drupal 7 version it is not well fixed.

If someone can give me some solution.

Thanks for help.

/**
 * Implements hook_form_BASE_FORM_ID_alter() for node form.
 */
function buangh_mantenimiento_diario_piscina_form_node_form_alter(&$form, FormStateInterface $form_state, $form_id): void {
  $node = $form_state->getFormObject()->getEntity();
  if ($node->getType() !== 'mantenimiento_diario_piscina') {
    return;
  }

// field hide/view
$form['field_operacion_filtro_mantenimi']['#states'] = [
  'visible' => [
    ':input[name^="field_operacion_de_mantenimiento[Limpieza del filtro]"]' => ['checked' => TRUE],
  ],
];
// field required
$form['field_operacion_filtro_mantenimi']['widget']['#states'] = [
  'required' => [
    ':input[name^="field_operacion_de_mantenimiento[Limpieza del filtro]"]' => ['checked' => TRUE],
  ],
];

}

Did you try the patch on this ticket?

For #26.

To see if a better solution can be had.

rebased for 10.1.1

Re #26, this doesn't seem to be a problem at the checkbox level. This form works and passes validation:

    $form['test-3293609'] = [
      '#type' => 'checkbox',
      '#title' => 'test 3293609',
      '#default_value' => TRUE,
      '#disabled' => TRUE,
      '#required' => TRUE,
    ];

    $form['submit'] = [
      '#type' => 'submit',
      '#value' => $this->t('Submit'),
    ];

This one with a checkboxes element fails validation:

    $form['test-3293609'] = [
      '#type' => 'checkboxes',
      '#title' => 'test 3293609',
      '#options' => [
        'alpha' => 'Alpha',
        'beta' => 'Beta',
      ],
      '#default_value' => [
        'alpha' => 'alpha',
      ],
      '#required' => TRUE,
    ];
    $form['test-3293609']['alpha']['#disabled'] = TRUE;

    $form['submit'] = [
      '#type' => 'submit',
      '#value' => $this->t('Submit'),
    ];

Rebased for 11.2.3