Problem/Motivation

When reviewing the patch in https://www.drupal.org/project/drupal/issues/3291100 I've noticed that as soon as the spinner shows up when opening the field settings in the manage display tab within a content type a shift of the label and format column takes place for a second. See the video. It has to be noted that the issue takes place with and without the patch from #3291100: Nested details element within content type's "manage display" UI changes width when opened applied, but with the patch applied it is more apparent, since it is the only unexpected shift/movement.

Steps to reproduce

1. Go to admin/structure/types/manage/article/display
2. Click the configure cog for the image field

=> you will notice a brief shift of the label and format column because the "Please wait" spinner is shown.

Proposed Solution

Render "Please wait" below the gear icon to prevent shifting.

Remaining tasks

Review
Manual testing of MR

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 Manage display _ drupal11OS.gif420.7 KBahsannazir
#6 3291221-after-patch.mov4.14 MBpradipmodh13
#6 3291221-before-patch.mov5 MBpradipmodh13
#4 Screen Recording 2023-05-09 at 2.24.26 PM.mov2.34 MBgauravvvv
#4 3291221-4.patch1.32 KBgauravvvv
spinner_triggering_shift.mov1.07 MBrkoller

Issue fork drupal-3291221

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rkoller created an issue. See original summary.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Issue summary: View changes

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3291221-4.patch1.32 KB
new Screen Recording 2023-05-09 at 2.24.26 PM.mov2.34 MB

I have provided a patch for same. Also I have added after patch screen recording file for the same. please review

pradipmodh13’s picture

pradipmodh13 commented
Assigned: Unassigned » pradipmodh13

Reviewing this ticket.

pradipmodh13’s picture

pradipmodh13 commented
Assigned: pradipmodh13 » Unassigned
StatusFileSize
new 3291221-before-patch.mov5 MB
new 3291221-after-patch.mov4.14 MB

#4 patch applied successfully. It is working fine as expected.
For ref attached video with before and after.
We can move to RTBC.
Thanks !

smustgrave’s picture

smustgrave commented
Priority: Normal » Minor
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Confirmed the "Please wait" appears below the gear icon. Will update IS with solution

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3291221-4.patch, failed testing. View results

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Gauravvvv opened merge request !7860

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Restoring previous status.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

The MR here was created on 1 May and then this was set to RTBC with no review of the MR. This should have a a review of the latest MR and manual testing of that. Setting back to NW.

ahsannazir’s picture

ahsannazir commented
StatusFileSize
new Manage display _ drupal11OS.gif420.7 KB

The code changes seems fine and the spinner is rendering below gear icon. Attaching screen capture for reference.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

#6 and #7 there was a review.

MR was just the patch that's why I restored status FYI.

  • nod_ committed 0181bb23 on 10.4.x 
    Issue #3291221 by Gauravvvv, pradipmodh13, rkoller, ahsannazir,...

  • nod_ committed 83ff161c on 11.0.x 
    Issue #3291221 by Gauravvvv, pradipmodh13, rkoller, ahsannazir,...

  • nod_ committed 35ca6308 on 11.x 
    Issue #3291221 by Gauravvvv, pradipmodh13, rkoller, ahsannazir,...

nod_ closed merge request !7860

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 35ca630848 to 11.x and 83ff161ced to 11.0.x and 0181bb23c1 to 10.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.