Problem/Motivation

When I’m filtering layout blocks by name in Layout builder I see a lot of empty spaces. Searching works correctly, but it would be much more convenient if it will look more compact as it was on D8.

CommentFileSizeAuthor
#13 3231919-13.patch803 bytesovanes
#10 After Patch 3231919.png405.26 KBchetanbharambe
#10 Before Patch 3231919.png512.04 KBchetanbharambe
#9 3231919-9.patch2.14 KBgauravvvv
#8 interdiff-2_8.txt1.78 KBgauravvvv
#8 3231919-8.patch1.97 KBgauravvvv
#2 filtering_layout_blocks-3231919-2.patch840 bytesnedaveleva
#2 Screenshot 2021-09-08 at 13.10.15.png163.14 KBnedaveleva
#2 image-20210831-190012.png36.04 KBnedaveleva
#2 image-20210831-190036.png24.35 KBnedaveleva

Comments

nedaveleva created an issue. See original summary.

nedaveleva’s picture

nedaveleva commented
StatusFileSize
new image-20210831-190036.png24.35 KB
new image-20210831-190012.png36.04 KB
new Screenshot 2021-09-08 at 13.10.15.png163.14 KB
new filtering_layout_blocks-3231919-2.patch840 bytes
nedaveleva’s picture

nedaveleva commented

Before patch:
before patchbefore patch

After patch:
after patch

nedaveleva’s picture

nedaveleva commented
nedaveleva’s picture

nedaveleva commented
Status: Active » Needs review
nedaveleva’s picture

nedaveleva commented
Issue summary: View changes
nedaveleva’s picture

nedaveleva commented
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3231919-8.patch1.97 KB
new interdiff-2_8.txt1.78 KB

Re-rolled patch #2, Attached interdiff for same.

Please update .pcss file, and run yarn run build:css to compile pcss to CSS. don't edit CSS file directly @nedaveleva

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3231919-9.patch2.14 KB
chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch 3231919.png512.04 KB
new After Patch 3231919.png405.26 KB

Verified and tested patch #9.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: admin/structure/types/manage/article/display/default/layout
# Goto: Bottom of the page
# Click on Add Block
# Search any block by respective name

Expected Results:
# User should not see a lot of empty spaces.

Actual Results:
# When the user filtering layout blocks by name in Layout builder then the user is able to see a lot of empty spaces.

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Closed (duplicate)
Related issues: +#3223048: Layout builder filter leaves blank space

This is a duplicate issue. The other one is fixing the JS. Please help test that code!

ovanes’s picture

ovanes commented
StatusFileSize
new 3231919-13.patch803 bytes

Hello I have rerolled patch filtering_layout_blocks-3231919-2.patch adjusted for core 9.5.x