Problem/Motivation

We shouldn't be calling drupal_flush_all_caches() directly in tests unless the test is testing drupal_flush_all_caches().

Proposed resolution

Remove call where possible OR replace with something better - ie. of smaller effect OR use $this->resetAll().

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3223267-2.patch6.33 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Active » Needs review
FileSize
3223267-2.patch6.33 KB
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

All code changes look good to me.
The patch does what the Is is saying.
For me it is RTBC.

  • catch committed 8abf81e on 9.3.x 
    Issue #3223267 by alexpott, daffie: Remove some calls to...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x. thanks!

  • catch committed 4d7c3c7 on 9.2.x 
    Issue #3223267 by alexpott, daffie: Remove some calls to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.