Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
media system
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Jul 2021 at 19:00 UTC
Updated:
3 Dec 2025 at 10:59 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
chris matthews commentedComment #3
chris matthews commentedRe-titling, 'cause I can't type.
Comment #8
anweshasinha commentedHi,
I have changed the media type description and added in patch. Please review the changes.
Comment #11
shivam-kumar commentedCreated a MR !6313 for the above patch.
Comment #12
shivam-kumar commentedMoved to needs review.
Comment #13
smustgrave commentedShould also be done in other spots used. Umami has media types also.
Comment #15
shweta__sharma commentedComment #16
shweta__sharma commentedTested MR 6313 changes are updated as per the proposed solution. Proposed#3 has been applied.
Thanks
Comment #17
kanchan bhogade commentedComment #18
kanchan bhogade commentedHi,
I have verified and tested MR !6313 on Drupal version 11.x for Standard and Umami
Testing steps:
Test Result:
The media type description has been updated, but the Media name should be Italic and
Image Description should - "Use Image for locally hosted image files ( use "for" not "or")
Attaching screenshots for reference.
Comment #19
smustgrave commented@bharath_kondeti this was tagged for novice just yesterday, which is intended for newer users. Based on your post history believe you should avoid novice issues in the future please
Comment #20
kazuko.murata commentedI came across this issue during the Drupal Contribution Day Japan 2025.
https://www.drupal.org/community/events/drupal-japan-contribution-day-ju...
It looks like both the Standard and Umami profiles' config have already been updated.
If there's anything left to be done, I'd be happy to work on it.
Comment #21
dcam commentedTagging for subsystem maintainer review to weigh in on which proposed description format we want to use.
If option 3 is chosen, then this needs to go back to Needs Work status to italicize the type name as noted in #18.
And in my opinion the issue summary needs to be updated because the text included in that image is not accessible. Someone should rewrite it into plain text in the summary.
Comment #22
jensdn commentedUpdated summary and remaining tasks
Comment #23
jensdn commentedComment #24
jensdn commentedComment #25
vijaycs85Comment #26
vijaycs85Comment #28
pguillard commentedChanged to single quotes
Comment #29
xjmI'm not sure where "proposed 3" came from, but it's not grammatically correct without the italics (e.g. "Use image for locally hosted image files" is missing an article).
Also, fewer words is better. So, if we're repeating "Use foo for [what foo is] every time when the context already makes it clear that we're talking about a foo, that's not helpful. Therefore, I'd propose we instead use the format like (e.g.):
"A locally hosted image file."
And standardize on the singular.
This will need the issue summary updated to reflect that new approach, and an updated MR. Thanks!
The Drupal Contribution Mentoring team is triaging issues for DrupalCon Nara 2025, and we are reserving this issue for Mentored Contribution during the event.
After November 19, this issue returns to being open to all. Thanks!
Comment #30
sourav_paulI agree with #29, as it sounds good & correct in context.
I’d like to contribute this issue — working on refining the description text patch as proposed.
Comment #31
sourav_paulHere is patch with proposed changes
It would be helpful, if anyone could review.
Comment #32
xjm@sourav_paul, are you contributing at DrupalCon Nara? If so, welcome, and come find one of the mentors tomorrow for help creating a proper merge request!
If not, please follow the green message in #29 until after November 19. Thanks!
Comment #33
hktang commentedHi all, I am at DrupalCon Nara 2025 and am working with my team to create a merge request.
Comment #34
h_bee commentedI am contributing on this issue with a team at Nara DrupalCon 2025
Comment #35
suryantoWe added a new approach as proposed 4 in the issue summary based on #29
Comment #36
hktang commentedOur team (@silverham, @h_bee, @suryanto, @rduterte, @akmalfikri and myself) proposed the above changes for review.
Comment #37
akmalfikri commentedI am contributing on this issue with a team at Nara DrupalCon 2025
Comment #38
h_bee commentedComment #39
h_bee commentedAfter the changes were put into a merge request, we reviewed the merge request. I added some small remarks about the quote format to be used, so it can become more consistent. I also updated the issue description for the next steps to be taken.
Comment #40
h_bee commentedComment #41
mradcliffeThis is amazing work, everyone.
Can we update the issue summary to mention which of the propose resolutions is the one in the merge request?
And then I think based on the discussion at the table in Nara, we decided to link the related issue about standardizing the quote formats, and then we can remove that as an action item and resolve the merge request threads.
Then remove the Needs issue summary update and I think we can change the status to RTBC!
Comment #42
h_bee commentedComment #43
h_bee commentedComment #44
h_bee commentedComment #45
xjmThanks for the great work on this everyone! I think we've come up with the best solution.
Now that we've settled on a proposed resolution, we can simplify the proposed resolution section to just say that several different proposals were considered, and to document the one we chose.
I agree with @rduterte's assessment that the issue of inconsistency between single and double quotes already has its own issue, and is therefore best not managed here. Good scope management! (There are legitimate cases for double quotes when strings contain apostrophes, for example, etc. etc.... and all that discussion would derail this issue, which is why we move the discussion outside this scope.)
I've made two very tiny suggestions on the merge request. If the contributors think these are good changes, then you can review them and mark the issue back to "Reviewed and tested by the community".
Comment #46
h_bee commentedThe issue summary has been changed and it has been reviewed again. The change(s) suggested by @xjm is/are integrated.
Comment #47
h_bee commentedComment #48
h_bee commentedComment #49
h_bee commentedComment #50
silverham commented(comment as helped with cherry pick of git code at DrupalCon Nara 2025)
Comment #53
xjmCommitted LIVE at DrupalCon Nara! Thanks to everyone who helped contribute to this issue over the past for years.
Cherry-picked to 11.3.x as a minor-safe string change.
Thanks!
Comment #56
sourav_paulAwesome team!
Nice to see that, it got resolved.