Problem/Motivation

While I was reviewing #3173832: Ensure Olivero's JS documentation matches standards, I noticed we still have scripts.js in the Olivero. This doesn't describe the functionality the file provides.

Proposed resolution

Rename scripts.js to something more descriptive.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3222313

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

paulocs’s picture

What you think about changing the file name to navigation-visibility.js?
Edit: I talked with Lauri and he suggested a less specific name. Maybe navigation-utils.js.

paulocs’s picture

Assigned: Unassigned » paulocs

Working on it.

paulocs’s picture

Assigned: paulocs » Unassigned
Status: Active » Needs review
imalabya’s picture

Status: Needs review » Reviewed & tested by the community

Checked the MR locally, navigation works properly after applying the changes. Moving to RTBC.

mherchel’s picture

navigation-utils.js makes sense to me! Haven't tested it, but since it passes all tests and its pretty basic, RTBC +!

alexpott’s picture

Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 101d892a36 to 9.3.x and 9bc2f9ee64 to 9.2.x. Thanks!

Backported to 9.2.x since olivero is experimental.

  • alexpott committed 101d892 on 9.3.x
    Issue #3222313 by paulocs: Rename scripts.js to something more...

  • alexpott committed 9bc2f9e on 9.2.x
    Issue #3222313 by paulocs: Rename scripts.js to something more...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.