Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
While I was reviewing #3173832: Ensure Olivero's JS documentation matches standards, I noticed we still have scripts.js in the Olivero. This doesn't describe the functionality the file provides.
Proposed resolution
Rename scripts.js to something more descriptive.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3222313
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
paulocsWhat you think about changing the file name to
navigation-visibility.js
?Edit: I talked with Lauri and he suggested a less specific name. Maybe
navigation-utils.js
.Comment #3
paulocsWorking on it.
Comment #5
paulocsComment #6
imalabyaChecked the MR locally, navigation works properly after applying the changes. Moving to RTBC.
Comment #7
mherchelnavigation-utils.js
makes sense to me! Haven't tested it, but since it passes all tests and its pretty basic, RTBC +!Comment #8
alexpottCommitted and pushed 101d892a36 to 9.3.x and 9bc2f9ee64 to 9.2.x. Thanks!
Backported to 9.2.x since olivero is experimental.