Document that the $table argument of Connection::select() can be a subquery

Looks much better

Two nitpicks:

1. +++ b/core/lib/Drupal/Core/Database/Connection.php
   @@ -1129,10 +1129,11 @@ public function exceptionHandler() {
   +   *   query_alter hook implementations.
   +   *   If a SelectInterface object, a subquery.
   

   Not outlined correctly.

2. +++ b/core/lib/Drupal/Core/Database/Query/Select.php
   @@ -123,8 +123,9 @@ class Select extends Query implements SelectInterface {
   +   *   If a string, the name of the table that is being queried.  If a
   

   Double space.

The documentation text is +1 for me.

@daffie
Added the changes as suggested. Please review it.

@sudipta: You have fixed #4.2 correctly, only #4.1 still needs to be done.

@daffie:

+++ b/core/lib/Drupal/Core/Database/Connection.php
@@ -1129,10 +1129,11 @@ public function exceptionHandler() {
+ * query_alter hook implementations.
+ * If a SelectInterface object, a subquery.

Not outlined correctly.

You want some text change or how it is, not getting it clearly.

+++ b/core/lib/Drupal/Core/Database/Connection.php
@@ -1129,10 +1129,11 @@ public function exceptionHandler() {
+   *   If a SelectInterface object is passed, it will be use as a subquery.

To be more clear. This text does not need to start on a new line. Look at the other change. "If a SelectInterface object ..." also does not start on a new line.

Given feedback addresses. Please review it.
As it is a small change, not added an interdiff.

+++ b/core/lib/Drupal/Core/Database/Connection.php
@@ -1129,10 +1129,11 @@ public function exceptionHandler() {
+   *   query_alter hook implementations. If a
+   *   SelectInterface, it will be use as a subquery.

still not aligned properly

1. +++ b/core/lib/Drupal/Core/Database/Connection.php
   @@ -1129,10 +1129,11 @@ public function exceptionHandler() {
   +   *   If a string, the base table for this query, that is, the first table in
   

   How about: The base table name or subquery for this query, used in the FROM clause. If a string, the table specified will also be used as the "base" table for query_alter hook implementations.

2. +++ b/core/lib/Drupal/Core/Database/Query/Select.php
   @@ -123,8 +123,9 @@ class Select extends Query implements SelectInterface {
   +   *   If a string, the name of the table that is being queried. If a
   

   How about just: The table name or subquery that is being queried.

Made changes suggested in #13.

Please review.

Good find. Committed to9.3.x and cherry-picked to 9.2.x. Thanks everyone!