Service deprecations are only triggered on container build,not ::get()

This one is going to be fun because we don't have the info from the ContainerBuilder so we're going to have to somehow provide it. Here's an approach with a compiler pass.

Let's see if we trigger any deprecations!

I found #2529516: Decouple tests from relying that $container is a container builder while trawling for Bug Smash Initiative, that seems at least tangentially related because of the finding in the upstream issue that deprecations work in kernel tests but not functional tests.

@longwave nice find - I agree related but not a blocker per se here.

Here's a test. The test only patch is the interdiff.

Fixing the deprecation now triggered in HEAD & fixing the test namespace so that run-tests.sh can run it.

Looks like a reasonable approach. We could add the deprecated definition to OptimizedPhpArrayDumper::getServiceDefinition() but that would only cover services - aliases would need special handling to extract and store their deprecation messages. The compiled container won't be much different so this method seems like far less code for the same result.

Good that we found a missed deprecation in our own code as well :)

Committed 70175bc and pushed to 9.3.x. Thanks!

Backported to 9.2.x

Nice solution

This was not a good approach as it is a SEVERE performance regression in the critical path.

At least move it later in the function.

It would indeed be better to put that into the dumper as that looks at every service anyway ...

Can we get a follow up issue @fsbianx?