Problem/Motivation

While trying to fix a problem with an error on uninstall, "checking" for things before uninstalling was the general solution. While searching for how to do that, it was a lot of not finding a mention of ModuleUninstallValidatorInterface.

Steps to reproduce

N/A

Proposed resolution

Add ModuleUninstallValidatorInterface hint to hook_uninstall docs.

Remaining tasks

  • get feedback on the idea. maybe another location?
  • TBD

User interface changes

N/A

API changes

Yes, to the docs, but not functionality.

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3214395

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT created an issue. See original summary.

YesCT opened merge request !683

YesCT’s picture

YesCT CreditAttribution: YesCT at Lullabot for Iowa State University commented
Status: Active » Needs review
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented

IMHO this should be added.
It will be easier to know how it should be implemented if a developer wants to add a verification that affects the admin UI.
Even if the ModuleUninstallValidatorInterface is well documented, it is more logical that the first thing a person will have in mind is use the hook_uninstall module.

I'll move to RTBC and see what the maintainers will say about it after the tests pass.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 518bcc2 on 9.3.x 
    Issue #3214395 by YesCT, paulocs: Add ModuleUninstallValidatorInterface...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Yes this is a good idea.

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

  • catch committed cb74725 on 9.2.x 
    Issue #3214395 by YesCT, paulocs: Add ModuleUninstallValidatorInterface...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.