Olivero: Mobile sub-navigation menus slightly offset subsequent menu links when hidden

Proposed solution:
Add margin: 0; to primary-nav__menu--level-2 class, when visibility: hidden;

CommentFileSizeAuthor
#6 interdiff-3_6.txt618 bytesgauravvvv
#6 3213118-6.patch1.06 KBgauravvvv
#5 Olivero_Theme_Demonstration.png397.13 KBmherchel
#4 after-3.png67.17 KBakhildev.cs
#4 before-3.png118.48 KBakhildev.cs
#3 3213118.2.patch1.08 KBsakthivel m
Screenshot 2021-05-10 at 13.08.16.png70.75 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Issue summary: View changes
sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
StatusFileSize
new 3213118.2.patch1.08 KB

#2 Please review the patch

akhildev.cs’s picture

akhildev.cs commented
StatusFileSize
new before-3.png118.48 KB
new after-3.png67.17 KB

hi,
#3 patch applied successfully, working fine for me. menu width in mobile view changed.
thankyou.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: Olivero: main menu item doesn't have equal spacing between them on the mobile screen. » Olivero: Mobile sub-navigation menus slightly offset subsequent menu links when hidden
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +CSS
StatusFileSize
new Olivero_Theme_Demonstration.png397.13 KB

Wow you have a really good eye to see this! I've looked at that menu so many times and never noticed.

One minor change. 

+++ b/core/themes/olivero/css/components/navigation/nav-primary.pcss.css
@@ -150,6 +150,8 @@
+  margin-top: 0;

You can replace these two lines with margin-block: 0;

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3213118-6.patch1.06 KB
new interdiff-3_6.txt618 bytes

Patch updated as suggested in #5.

Interdiff attached. thanks

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Looks perfect!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 3213118-6.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Reviewed & tested by the community

Unrelated failure, moving back to RTBC

  • lauriii committed 9a74649 on 9.3.x 
    Issue #3213118 by Gauravmahlawat, Sakthivel M, Akhildev.cs, mherchel:...

  • lauriii committed 8b4e680 on 9.2.x 
    Issue #3213118 by Gauravmahlawat, Sakthivel M, Akhildev.cs, mherchel:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 9a74649 and pushed to 9.3.x. Also cherry-picked to 9.2.x because Olivero is experimental. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.