Olivero: aside region 33/33/33 layout broken in IE11.

Can be seen on live preview: https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/node/32

Adding screenshot for reference.

Proposed resolution

@media (min-width: 43.75rem)
.region--content-below > * {
    flex-basis: calc(33.33% - 1.4985rem);
}

change to 

@media (min-width: 43.75rem)
.region--content-below > * {
    flex-basis: calc(33.32% - 1.4985rem);
}
CommentFileSizeAuthor
#5 3212704-5.patch1.06 KBgauravvvv
Screenshot 2021-05-07 at 12.03.18.png28.29 KBgauravvvv
Screenshot 2021-05-07 at 12.02.53.png60.94 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Closed (duplicate)

This is a duplicate of #3211888: Olivero: Layout Builder 33/34/33 layout broken in IE11

gauravvvv’s picture

gauravvvv commented
Status: Closed (duplicate) » Active

The above issues you mentioned is layout builder issue and fixed fro layout builder layout only. this issue is still present at live preview https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/node/32 Please review once.

this is the patch fro layout builder page we fixed in the above issue.

--- a/core/themes/olivero/css/layout/layout-builder-threecol-section.css
 }

This needs to be fixed in region content below file too.
a/core/themes/olivero/css/layout/region-content-below.css

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3212704-5.patch1.06 KB

@mherchel, Please review the patch.

I have made changes in a/core/themes/olivero/css/layout/region-content-below.css file.

This issue is related to the content region below, not to the layout builder.

thanks.

gauravvvv’s picture

gauravvvv commented
Title: Olivero: aside region 33/33/33 layout broken in IE11 » Olivero: content below region 33/33/33 layout broken in IE11
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

You're right! Sorry, I didn't read through.

Thanks for the patch. It looks perfect!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed b9a52da and pushed to 9.3.x and 9.2.x. Thanks!

  • lauriii committed b9a52da on 9.3.x 
    Issue #3212704 by Gauravmahlawat, mherchel: Olivero: content below...

  • lauriii committed fb7be27 on 9.2.x 
    Issue #3212704 by Gauravmahlawat, mherchel: Olivero: content below...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.