Closed (fixed)
Project:
Drupal core
Version:
9.2.x-dev
Component:
update.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 May 2021 at 18:40 UTC
Updated:
27 May 2021 at 12:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
guilhermevp commentedSending patch. Please review.
Comment #3
tedbow@guilhermevp thanks for the patch!
we need comments for why the exception is thrown. You can get an idea from the exception message and search in core for example messsages that go with @throws
Comment #4
guilhermevp commentedThanks for the feedback! I will do it!
Comment #5
guilhermevp commentedSending new patch, please review.
Comment #6
guilhermevp commentedComment #7
tedbow@guilhermevp thanks for updating the patch. Here are a couple suggestions to make it extra clear to developers who get these exceptions what the problem
The only reason I know these reasons is because I helped add this class(and forgot to add the descriptions at the time 😞)
I think we should add some more context.
how about
Thrown when a legacy version string has a core prefix other than "8.x-". For example, version strings such as "7.x-1.0" are not supported.I think we should change this because a "supported branch" in Drupal has special meaning.
For instance 8.9.x is a supported and 8.7.x is not supported currently.
But the exception here is because the parameter
$branchis an invalid string that does not end with "."So maybe
Thrown when $branch invalid because it does not end in "."Comment #8
guilhermevp commentedWorking on it!
Comment #10
guilhermevp commentedComment #11
phenaproximaOne small grammatical fix and then I think this is RTBC!
Comment #12
guilhermevp commentedComment #13
phenaproximaAh, sorry, I should have maybe been clearer in my review...!
Comment #14
guilhermevp commentedThanks @phenaproxima! Sometimes my english just breaks.
Comment #15
phenaproximaBoom! Looks great.
Comment #16
tedbowThanks @guilhermevp and @phenaproxima!!!!
Comment #18
catchCommitted ba7c2c5 and pushed to 9.3.x. Thanks! Also cherry-picked to 9.2.x