Problem/Motivation

When editing a node, preview is not viewable if the user is going to be blocked by the new revision's editing page (after saving).
The behavior is counterintuitive... the users should be able to see preview as long as they can access editing page.

Steps to reproduce

- Install Content Moderation
- Create a workflow with moderation states "Draft" and "Published".
- Allow authenticated users to use only "Draft"->"Published" transition (which makes authenticated users unable to edit "Published" revisions.)
- Login as an authenticated user and open a node edit page whose current status is "Draft"
- Set "Published" as next moderation state
- Push "Preview" button

Proposed resolution

Check access on latest revision instead of new revision

Issue fork drupal-3201661

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

863 created an issue. See original summary.

snitta’s picture

snitta commented
Issue summary: View changes

snitta opened merge request !405

snitta’s picture

snitta commented
Issue summary: View changes
snitta’s picture

snitta commented
Title: Access denied on node preview page when the user cannot access the new revision » Access denied on node preview page when the user will be blocked by the future revision
cilefen’s picture

cilefen commented
Status: Active » Needs review

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Can the MR be updated for 10.1 please

Also will need a test case to show the issue.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley’s picture

acbramley commented
Issue tags: +Needs reroll

Needs a reroll/rebase on to 11.x and still needs tests

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.