Problem/Motivation

In PhpUnitCompatibilityTrait.php there is a comparison that takes place that can never be true because the letter u of Unit is lowercase in one place and upper case in another. As linux is case sensitive the trait will always be re-created. Marking as minor because it doesn't break anything.

if (!trait_exists(PhpunitVersionDependentTestCompatibilityTrait::class, FALSE)) {
  class_alias("Drupal\TestTools\PhpUnitCompatibility\PhpUnit" . RunnerVersion::getMajor() . "\TestCompatibilityTrait", PhpUnitVersionDependentTestCompatibilityTrait::class);
}

Steps to reproduce

N/A

Proposed resolution

Make the cases match.

Remaining tasks

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

Issue fork drupal-3201113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

achap created an issue. See original summary.

longwave’s picture

Status: Active » Reviewed & tested by the community

Oh, nice find!

alexpott’s picture

Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 24eb025a56 to 9.2.x and ebf2c6e2ff to 9.1.x. Thanks!

  • alexpott committed 24eb025 on 9.2.x
    Issue #3201113 by achap: PhpunitVersionDependentTestCompatibilityTrait...

  • alexpott committed ebf2c6e on 9.1.x
    Issue #3201113 by achap: PhpunitVersionDependentTestCompatibilityTrait...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.