Problem/Motivation

This issue is to add documentation for the following source plugins:

  • d6/Field.php
  • d6/FieldInstanceOptionTranslation.php
  • d6/FieldInstancePerFormDisplay.php
  • d6/FieldInstancePerViewMode.php
  • d6/FieldInstance.php
  • d6/FieldLabelDescriptionTranslation.php
  • d6/FieldOptionTranslation.php

Proposed resolution

Do it.

Remaining tasks

Review, commit.

Issue fork drupal-3200809

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Matroskeen created an issue. See original summary.

Matroskeen’s picture

Status: Active » Needs review

I decided to split field source plugins into two sub-tasks, for d6 and d7 plugins.
If you feel comfortable reviewing all field plugins here, please let me know and I'll add another commit.

quietone’s picture

Status: Needs review » Needs work

I applied the patch and read all the changes. I checked for parent classes that add configuration keys to check that nothing was missed in the new @see statements. There wasn't, they are all correct.

+1 for the consistency of the Summary lines.

I wasn't sure if the field should be split by the source database but seeing this MR I think it is a good decision. I don't have to think about any differences between the two source database when reviewing. It is simpler.

There is one resolved issue, setting NW for that.

Matroskeen’s picture

Status: Needs work » Needs review

Done! 👍

quietone’s picture

Status: Needs review » Reviewed & tested by the community

@Matroskeen, thanks!

Another one done.

  • catch committed 6ac3bcd on 9.2.x
    Issue #3200809 by Matroskeen, quietone: Add documentation for d6 field...

  • catch committed 7286dd7 on 9.1.x
    Issue #3200809 by Matroskeen, quietone: Add documentation for d6 field...
catch’s picture

Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks.

- * The field instance per form display source class.
+ * Drupal 6 field instance per form display source from database.
+ *

This is a bit hard to scan, but it's also accurate, and similar to what was there before, and I don't have a better suggestion.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.