Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
This issue is to add documentation for the following source plugins:
- d6/Field.php
- d6/FieldInstanceOptionTranslation.php
- d6/FieldInstancePerFormDisplay.php
- d6/FieldInstancePerViewMode.php
- d6/FieldInstance.php
- d6/FieldLabelDescriptionTranslation.php
- d6/FieldOptionTranslation.php
Proposed resolution
Do it.
Remaining tasks
Review, commit.
Issue fork drupal-3200809
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3200809-documentation-d6-field-plugins changes, plain diff MR !368
Comments
Comment #3
MatroskeenI decided to split field source plugins into two sub-tasks, for d6 and d7 plugins.
If you feel comfortable reviewing all field plugins here, please let me know and I'll add another commit.
Comment #4
quietone CreditAttribution: quietone as a volunteer commentedI applied the patch and read all the changes. I checked for parent classes that add configuration keys to check that nothing was missed in the new @see statements. There wasn't, they are all correct.
+1 for the consistency of the Summary lines.
I wasn't sure if the field should be split by the source database but seeing this MR I think it is a good decision. I don't have to think about any differences between the two source database when reviewing. It is simpler.
There is one resolved issue, setting NW for that.
Comment #5
MatroskeenDone! 👍
Comment #6
quietone CreditAttribution: quietone as a volunteer commented@Matroskeen, thanks!
Another one done.
Comment #9
catchCommitted/pushed to 9.2.x and cherry-picked to 9.1.x, thanks.
This is a bit hard to scan, but it's also accurate, and similar to what was there before, and I don't have a better suggestion.