Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Found in #3153260: Standardize Olivero's focus states across all non-form controls.
Olivero has an unneeded CSS class where it styles text if CKEditor is in the footer region.
It's extremely unlikely a user will add the CKEditor into the footer, so this class can be removed.
Comment | File | Size | Author |
---|---|---|---|
#15 | interdiff_8-15.txt | 1.77 KB | mike.roman |
#12 | 3200599-9.patch | 2.07 KB | mike.roman |
#10 | 3200599-patch.png | 127.2 KB | meghasharma |
#8 | 3200599-8.patch | 1.45 KB | imalabya |
#7 | 3200599_07.patch | 1.53 KB | hinal05 |
Comments
Comment #2
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commentedI have removed the class, Please review.
Comment #3
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commentedComment #4
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commentedComment #5
BhumikaVarshney CreditAttribution: BhumikaVarshney as a volunteer and at OpenSense Labs commentedComment #6
mherchelthe testing suite is not able to apply the attached patches.
Comment #7
hinal05 CreditAttribution: hinal05 as a volunteer and at QED42 for Drupal India Association commentedPlease review the patch.
Comment #8
imalabyaRe-rolled the patch.
Comment #9
Madhu kumar CreditAttribution: Madhu kumar as a volunteer and commentedPatch #8 applied cleanly and it is working well.
Comment #10
meghasharma CreditAttribution: meghasharma as a volunteer and at QED42 for Drupal India Association commentedPatch #8 applied cleanly and it is working well.
Looks good to me
screenshot for reference.
No need for cke_editable class in footer CSS issue RESOLVED
The cke_editable class has removed from text-content.css file.
RTBC
Comment #11
mherchelThis works, but should be simplified to
.site-footer .text-content { }
since there is now only one descendent selector.@meghasharma, screenshots of code do not help, as the testing infrastructure will let us know if the patch does not apply.
Comment #12
mike.roman CreditAttribution: mike.roman at Clarity Partners commentedI made changes to imalabya's "-8" patch based on mherchel's recommendation. I'll try to get an interdiff uploaded later. #midcamp2021
Comment #13
mike.roman CreditAttribution: mike.roman at Clarity Partners commentedComment #14
mradcliffeAdding tag.
Comment #15
mike.roman CreditAttribution: mike.roman at Clarity Partners commentedFollowing up on my comment #12, this is the interdiff file.
Comment #16
mherchel#14 looks great. Thanks!
Comment #18
mherchelTest failure was unrelated. Setting back to RTBC
Comment #19
lauriiiThis looks good as well. I believe that the
.site-footer .cke_editable
selector would never be applied because.cke_editable
is used inside the iframe content. I will get back to this in a couple of days after the security release window.Comment #21
lauriiiCommitted 569ac38 and pushed to 9.2.x. Thanks!