Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

Gauravvvv’s picture

Gauravvvv’s picture

Status: Active » Needs review
Gauravvvv’s picture

BhumikaVarshney’s picture

mherchel’s picture

Status: Needs review » Needs work

the testing suite is not able to apply the attached patches.

hinal05’s picture

Status: Needs work » Needs review
FileSize
1.53 KB

Please review the patch.

imalabya’s picture

Re-rolled the patch.

Madhu kumar’s picture

Patch #8 applied cleanly and it is working well.

meghasharma’s picture

FileSize
127.2 KB

Patch #8 applied cleanly and it is working well.
Looks good to me
screenshot for reference.
No need for cke_editable class in footer CSS issue RESOLVED
The cke_editable class has removed from text-content.css file.
RTBC

mherchel’s picture

Status: Needs review » Needs work
+++ b/core/themes/olivero/css/components/text-content.pcss.css
@@ -142,8 +142,7 @@
+  & .text-content {

This works, but should be simplified to .site-footer .text-content { } since there is now only one descendent selector.

@meghasharma, screenshots of code do not help, as the testing infrastructure will let us know if the patch does not apply.

mike.roman’s picture

I made changes to imalabya's "-8" patch based on mherchel's recommendation. I'll try to get an interdiff uploaded later. #midcamp2021

mike.roman’s picture

Status: Needs work » Needs review
mradcliffe’s picture

Issue tags: +midcamp2021

Adding tag.

mike.roman’s picture

FileSize
1.77 KB

Following up on my comment #12, this is the interdiff file.

mherchel’s picture

Status: Needs review » Reviewed & tested by the community

#14 looks great. Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: 3200599-9.patch, failed testing. View results

mherchel’s picture

Status: Needs work » Reviewed & tested by the community

Test failure was unrelated. Setting back to RTBC

lauriii’s picture

This looks good as well. I believe that the .site-footer .cke_editable selector would never be applied because .cke_editable is used inside the iframe content. I will get back to this in a couple of days after the security release window.

  • lauriii committed 569ac38 on 9.2.x
    Issue #3200599 by Gauravmahlawat, mike.roman, BhumikaVarshney, hinal05,...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Committed 569ac38 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.