Split off from #3176893: Make the book navigation markup and CSS in Olivero follow BEM.

Olivero's book pager needs to be converted to use BEM.

CommentFileSizeAuthor
#5 Phasellus_justo_diam___Olivero.png228.61 KBmherchel
#2 3196874-1.patch5.47 KBandy-blum
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
CreditAttribution: andy-blum as a volunteer commented
Status: Active » Needs review
FileSize
3196874-1.patch5.47 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 2: 3196874-1.patch, failed testing. View results

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
CreditAttribution: andy-blum as a volunteer commented
Status: Needs work » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
Phasellus_justo_diam___Olivero.png228.61 KB

This looks perfect. Thanks!

RTBC!

  • lauriii committed f429aba on 9.2.x 
    Issue #3196874 by andy-blum, mherchel: BEMifying Olivero's book pager
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

The markup and CSS looks awesome! Thank you!

Committed f429aba and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.