Problem/Motivation

This issue is to add documentation for the following source plugins:

  • VariableMultiRow.php
  • Variable.php
  • d6/VariableTranslation.php
  • d7/VariableTranslation.php

See parent issue for more context.

Remaining tasks

Review and commit.

Issue fork drupal-3196177

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Matroskeen created an issue. See original summary.

Matroskeen opened merge request !289

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Active » Needs review
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work

NW for the review in the MR

anmolgoyal74 made their first commit to this issue’s fork.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented

@quietone
All the suggestions has been addressed.

For core/modules/migrate_drupal/src/Plugin/migrate/source/Variable.php, I have updated it differently.
Can you please review it?

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Needs review

I think current threads can be resolved. Moving back to NR.
@anmolgoyal74, @quietone thanks!

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work

Sorry, I found one more grammar correction.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Needs review

As a non-native speaker, I'm trying to constantly use Grammarly. Sometimes I forget...

I'm also sorry because I applied more changes and you'll need to review it again. I self-reviewed the changes and decide to replace some parts to be consistent with other merge requests for meta issue:

  • will be returned -> are retrieved
  • source -> source database
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

Oh, we going down the grammar rabbit hole. Whee!

It was good you made the extra changes (I love consistency) because I caught another one.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Needs review

Let's see if I passed the grammar exam this time :)

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Haha. I may be a native English speaker but I did poorly on grammar exams. Thankfully, my partner is good at grammar and I am good at spelling so we make a good team.

Looks good now, thanks for sticky with this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +Documentation

Committed and pushed 490eceaf44 to 9.2.x and 3072e44909 to 9.1.x. Thanks!

  • alexpott committed 490ecea on 9.2.x 
    Issue #3196177 by Matroskeen, anmolgoyal74, quietone: Add documentation...

  • alexpott committed 3072e44 on 9.1.x 
    Issue #3196177 by Matroskeen, anmolgoyal74, quietone: Add documentation...

Matroskeen closed merge request !289

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.