Problem/Motivation

In CreateSampleEntityTest.php test in setUp() method, the following line is added twice:
$this->installEntitySchema('file');
code

Steps to reproduce

Open the CreateSampleEntityTest.php and take a look into setUp() method content.

Proposed resolution

Remove extra $this->installEntitySchema('file');

CommentFileSizeAuthor
#2 3195628-2.patch701 bytesMatroskeen
Screen Shot on 2021-01-30 at 22:53:05.png242 KBMatroskeen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Matroskeen created an issue. See original summary.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Drupal Ukraine Community commented
Status: Active » Needs review
FileSize
3195628-2.patch701 bytes
Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Drupal Ukraine Community commented
Issue tags: +GlobalContributionWeekend2021
rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
CreditAttribution: rachel_norfolk at Drupal Association commented
Issue tags: -GlobalContributionWeekend2021 +ContributionWeekend2021

Just doing a little tag tidying. Nice work everyone!!

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte commented
Status: Needs review » Reviewed & tested by the community

Thanks for the issue and patch!

1) Confirmed that the issue exists in the test.

2) Patch still applies to 9.2.

3) Tests pass.

4) Code looks good and addresses the change in the summary.

5) No manual testing is needed as this is in a test and tests pass.

Marking RTBC!

  • catch committed 3d8a696 on 9.2.x 
    Issue #3195628 by Matroskeen, Kristen Pol: CreateSampleEntityTest...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 3d8a696 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.