Problem/Motivation

The source plugin for d6_taxonomy_term_localized_migration gets all the terms but does not filter out the ones not using a localized vocabulary.

This was discovered while working on #3082211: Migrate UI upgrade tests should provide the complete log because, for unknown reasons, Upgrade6Test produces a different number of error messages locally vs drupalci.

Steps to reproduce

Proposed resolution

Add a condition to the query to only get translations of type 'term'.

Remaining tasks

Patch
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3193189-4.patch3.52 KBquietone
#3 3193189-3.patch21.79 KBquietone
#3 interdiff-2-3.txt3.05 KBquietone
#2 3193189-2.patch18.52 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Active » Needs review
FileSize
3193189-2.patch18.52 KB

And the patch. This was included in a patch in the related issue, #31 and all tests pass.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
FileSize
interdiff-2-3.txt3.05 KB
3193189-3.patch21.79 KB

The source plugin test should be updated as well.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
FileSize
3193189-4.patch3.52 KB

The first thing I did was compare with the Drupal7 version - but I missed the difference. It is just one line in the query method that was missing, $query->condition('i18n.type', 'term');

This is a better solution.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Title: Skip non localized vocabularies in d6_taxonomy_term_localized_translation » Get only translations for localized vocabularies d6/TermLocalizedTranslation.php

More accurate title

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue tags: +Bug Smash Initiative
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

I can confirm that the fix is the same as d7/TermLocalizedTranslation.php so RTBC.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3193189-4.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Tests are passing on 9.3.x, restoring RTBC.

  • catch committed eddba9a on 9.3.x 
    Issue #3193189 by quietone, jibran: Get only translations for localized...

  • catch committed a764279 on 9.2.x 
    Issue #3193189 by quietone, jibran: Get only translations for localized...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

Doesn't apply to 9.1.x, but there's a short window to get bugfixes into 9.1.x anyway, so just marking fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.