Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
We're working towards replacing assertIdentical with assertSame. assertSame requires the arguments to be ($expected, $actual, ...), whereas assertIdentical requires ($actual, $expected,...).
Proposed resolution
In preparation for the final cleanup, change all assertIdentical calls checking for NULL to assertNull.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3192553
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3192553-convert-assertidenticalnull-to changes, plain diff MR !252
Comments
Comment #3
mondrakeComment #4
longwaveCopy/paste error in one of the files, otherwise this looks good. Happy that we broke this out, might not have spotted that in the 600 lines of the other MR.
Comment #5
mondrakeComment #6
longwaveLooks good now.
Comment #7
longwaveScratch that, there is a parse error due to an extra bracket.
Comment #8
mondrakeComment #9
longwaveRTBC if tests pass this time!
Comment #12
catchCommitted/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!