Problem/Motivation

We're working towards replacing assertIdentical with assertSame. assertSame requires the arguments to be ($expected, $actual, ...), whereas assertIdentical requires ($actual, $expected,...).

Proposed resolution

In preparation for the final cleanup, change all assertIdentical calls checking for NULL to assertNull.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3192553

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Status: Active » Needs review
longwave’s picture

Status: Needs review » Needs work

Copy/paste error in one of the files, otherwise this looks good. Happy that we broke this out, might not have spotted that in the 600 lines of the other MR.

mondrake’s picture

Status: Needs work » Needs review
longwave’s picture

Status: Needs review » Reviewed & tested by the community

Looks good now.

longwave’s picture

Status: Reviewed & tested by the community » Needs work

Scratch that, there is a parse error due to an extra bracket.

mondrake’s picture

Status: Needs work » Needs review
longwave’s picture

Status: Needs review » Reviewed & tested by the community

RTBC if tests pass this time!

  • catch committed b7dd784 on 9.2.x
    Issue #3192553 by mondrake, longwave: Convert assertIdentical(NULL..) to...

  • catch committed aa96f0d on 9.1.x
    Issue #3192553 by mondrake, longwave: Convert assertIdentical(NULL..) to...
catch’s picture

Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.