Problem/Motivation

AssertLegacyTrait::assertNotEqual() is deprecated in drupal:8.0.0 and is removed from drupal:10.0.0. Use $this->assertNotEquals() instead. See https://www.drupal.org/node/3129738

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#12 3192427-12.patch62.03 KBmondrake

Issue fork drupal-3192427

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !250

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Active » Needs review
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Needs work

Just one comment.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Needs review
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

All instances of AssertLegacyTrait::assertNotEqual have been replaced.
There is a deprecation message test added.
The deprecatin message is no longer suppressed.
All code changes look good to me.
For me it is RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs review

One question on the PR. Everything else looks fine - presumably removing the custom assertion messages will be handled in another issue.

We should probably backport this to 9.1.x (without the deprecation unsupression) too.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D9.1

#7 actually the custom assertion messages are legitimate here, assertNotEquals allows them - in case we want to remove we need a follow-up, I don't think there's one.

Agreed a D9.1 backport w/o deprecations is appropriate.

Replied in MR to @catch's comment.

  • catch committed 39bacf4 on 9.2.x 
    Issue #3192427 by mondrake, daffie: Replace usages of deprecated...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: -Needs backport to D9.1 +Needs reroll

Committed 39bacf4 and pushed to 9.2.x. Thanks!

Let's backport this to 9.1.x - but needs a reroll at least with the deprecation unsuppression removed.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Title: Replace usages of deprecated AssertLegacyTrait::assertNotEqual » [backport] Replace usages of deprecated AssertLegacyTrait::assertNotEqual
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3192427-12.patch62.03 KB

Rerolled for 9.1.x

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Setting to RTBC. I only added back deprecation silencer and removed the deprecation test.

  • catch committed 6c3e0a0 on 9.1.x 
    Issue #3192427 by mondrake, daffie: Replace usages of deprecated...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 6c3e0a0 and pushed to 9.1.x. Thanks!

mondrake closed merge request !250

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.