Problem/Motivation

In Drupal 6 or in Drupal 7, a block which has its title set to '<none>' is rendered without its label displayed, similarly to an empty label. But right now, this behaviour isn't reflected in block configuration migration: blocks with label '<none>' are migrated with $settings['label_display'] = BlockPluginInterface::BLOCK_LABEL_VISIBLE;.

See:

Proposed resolution

Modify the block_settings migrate process plugin to migrate block configs with title '<none>' with non-displayed block title.

Remaining tasks

  • Patch
  • Test coverage

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3191490-11.patch2.83 KBquietone
#11 3191490-11-fail.patch2.16 KBquietone

Issue fork drupal-3191490

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

huzooka created an issue. See original summary.

huzooka opened merge request !226

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

Let's see what breaks.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs work
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

Code looks good, now just needs tests — nice catch! 👍

quietone made their first commit to this issue’s fork.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Novice, -Needs tests

Beautiful, thank you @quietone!

* Tests the blocks settings process plugin..

→ double period at the end.

I tried fixing it via the GitLab Web IDE but it wouldn't allow me 🙈

quietone’s picture

quietone commented

The change since RTBC was to change '..' to '.' in a doc bloc and tests are still passing so leaving at RTBC.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Might be good to upload a failing test-only patch. I don't think that's possible to do with a merge request?

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3191490-11-fail.patch2.16 KB
new 3191490-11.patch2.83 KB

Adding fail patch and re-uploading the success patch so that will get tested every 2 days.

The last submitted patch, 11: 3191490-11-fail.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

This deserves getting back the RTBC status.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3191490-11.patch, failed testing. View results

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

Random test failure of Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderQuickEditTest.

See https://www.drupal.org/pift-ci-job/1951161

  • catch committed 543caad on 9.2.x 
    Issue #3191490 by quietone, huzooka, Wim Leers: Migrate d6 and d7 block...

  • catch committed 3f79ed9 on 9.1.x 
    Issue #3191490 by quietone, huzooka, Wim Leers: Migrate d6 and d7 block...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.