Problem/Motivation

There is remaining text in RequestContext that 1/ won't materialize, and 2/ more methods have since been added so that comment does no longer stand anyway.

* @todo: Remove once the upstream RequestContext provides fromRequestStack():
* https://github.com/symfony/symfony/issues/12057

Proposed resolution

Remove it.

CommentFileSizeAuthor
#2 3191061-request-context.patch524 bytesjcisio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jcisio created an issue. See original summary.

jcisio’s picture

jcisio CreditAttribution: jcisio as a volunteer and at Axess Open Web Services commented
Status: Active » Needs review
FileSize
3191061-request-context.patch524 bytes
cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented
Issue tags: +Documentation
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Category: Bug report » Task
Issue tags: +Bug Smash Initiative

Thanks, this is a task, not a bug

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Yes, this todo can be removed. The Symfony issue has been closed and they are not adding the method.

  • catch committed af458de on 9.3.x 
    Issue #3191061 by jcisio, quietone: Remove todo in class Drupal\Core\...

  • catch committed 2a66fb6 on 9.2.x 
    Issue #3191061 by jcisio, quietone: Remove todo in class Drupal\Core\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.