Error: Call to a member function getTotalCount() on bool in statistics_tokens()

@pavnish: Could you tell a bit more how you got the error message. Helps with understanding how you got this error and how to fix it. Could you tell why you think this issue is "critical". See: https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-....

When I take a look at the interface of Drupal\statistics\StatisticsStorageInterface is see that the method fetchView() returns the expected result of FALSE:

  /**
   * Returns the number of times a single entity has been viewed.
   *
   * @param int $id
   *   The ID of the entity to fetch the views for.
   *
   * @return \Drupal\statistics\StatisticsViewsResult|false
   *   If the entity exists, a value object representing the number of times if
   *   has been viewed. If it does not exist, FALSE is returned.
   */
  public function fetchView($id);

My suggestion would be to test the return value and only then call getTotalCount(). Just like you are suggestion in comment #2.

Uploaded patch for this issue, @pavnish please review.

I do not like the patch from comment #6. The method fetchView() is called twice and the fetchView() calls fetchViews(). The fetchViews() runs every time it gets called a database query. I think that it is better to store the result of fetchView() is a variable and then test the value of that variable.

@pavnish: That is better, only now will the view be loaded every time there are tokens when the type is 'node' even when there are no tokens with the name: 'total-count', 'day-count' or 'last-view'. Therefore the view will be loaded lots of times when it is not necessary. The code change I was looking for is something like:

      if ($name == 'total-count') {
        $node_view = $stats_storage->fetchView($node->id());
        $replacements[$original] = ($node_view) ? $node_view->getTotalCount() : 0;
      }

The same for 'day-count' and 'last-view'. Also, we need testing for this change.

Now we only need the testing to be added.

+++ b/core/modules/statistics/statistics.tokens.inc
@@ -44,13 +44,16 @@ function statistics_tokens($type, $tokens, array $data, array $options, Bubbleab
-        $replacements[$original] = \Drupal::service('date.formatter')->format($stats_storage->fetchView($node->id())->getTimestamp());
+        $node_view = $stats_storage->fetchView($node->id());
+        $replacements[$original] = \Drupal::service('date.formatter')->format($node_view->getTimestamp());

This change does not help fixing the bug, therefore it can be removed.

Reverted the change suggested in #15. Please review.

Now we only need the testing to be added.

Added tests. I think we should also fix the error for the 'last-view' token.

@WalkingDexter: Thak you for adding the tests!

The patch is for me almost RTBC.

1. +++ b/core/modules/statistics/statistics.tokens.inc
   @@ -40,22 +40,29 @@ function statistics_tokens($type, $tokens, array $data, array $options, Bubbleab
   +    $node_view = NULL;
   ...
   +        $node_view = $node_view ?? $stats_storage->fetchView($node->id());
   ...
   +        $node_view = $node_view ?? $stats_storage->fetchView($node->id());
   ...
   +        $node_view = $node_view ?? $stats_storage->fetchView($node->id());
   ...
   +      $node_view = $node_view ?? $stats_storage->fetchView($node->id());
   

   I like this change. Now the view gets only loaded once.

2. +++ b/core/modules/statistics/statistics.tokens.inc
   @@ -40,22 +40,29 @@ function statistics_tokens($type, $tokens, array $data, array $options, Bubbleab
   -      $replacements += $token_service->generate('date', $created_tokens, ['date' => $stats_storage->fetchView($node->id())->getTimestamp()], $options, $bubbleable_metadata);
   +      $node_view = $node_view ?? $stats_storage->fetchView($node->id());
   +      $replacements += $token_service->generate('date', $created_tokens, ['date' => $node_view ? $node_view->getTimestamp() : 0], $options, $bubbleable_metadata);
   

   There is no testing for this change.

Improved tests.

@walkingdexter: Could you create an interdiff file. It makes reviewing a lot easier. See: https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...

Sure.

Hmm...strange error. Running a new test.

The test was successful, that's better :)

The bug is fixed in the patch.
There is also testing for the fix.
All code changes look good to me.
For me it is RTBC.

@walkingdexter: Thank you for working on the patch!

Committed/pushed to 9.3.x, cherry-picked to 9.2.x and 9.1.x, thanks!