Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In #2729369: Remove support for migrating temporary files there was removed support for migrating temporary files.
However, in the d7/File.sql source plugin, we still have $temporaryPath property and attempt to replace "temporary:/" to the real path.
It seems it doesn't make sense, because files with "temporary:/" scheme will be filtered out in the query.
Proposed resolution
Remove $temporaryPath and it's usage in d7/File source plugin.
Remaining tasks
- Review
- Commit
Issue fork drupal-3189878
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3189878-remove-temporary-path
changes, plain diff MR !186
1 hidden branch
Comments
Comment #3
MatroskeenTests passed. Moving to NR.
Comment #4
MatroskeenComment #5
quietone CreditAttribution: quietone as a volunteer commentedI reviewed the MR and this looks like a nice bit of cleanup to me.
The references to the path to the temporary file remain in the query, with no change, so that temporary files are excluded from the query results. All other reference to the temporary scheme are removed.
Thanks!
Comment #6
alexpottCommitted c61a9d4 and pushed to 9.2.x. Thanks!