Problem/Motivation

In #2729369: Remove support for migrating temporary files there was removed support for migrating temporary files.

However, in the d7/File.sql source plugin, we still have $temporaryPath property and attempt to replace "temporary:/" to the real path.

It seems it doesn't make sense, because files with "temporary:/" scheme will be filtered out in the query.

Proposed resolution

Remove $temporaryPath and it's usage in d7/File source plugin.

Remaining tasks

  • Review
  • Commit

Issue fork drupal-3189878

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Matroskeen created an issue. See original summary.

Matroskeen opened merge request !186

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Active » Needs review

Tests passed. Moving to NR.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

I reviewed the MR and this looks like a nice bit of cleanup to me.

The references to the path to the temporary file remain in the query, with no change, so that temporary files are excluded from the query results. All other reference to the temporary scheme are removed.

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c61a9d4 and pushed to 9.2.x. Thanks!

  • alexpott committed c61a9d4 on 9.2.x 
    Issue #3189878 by Matroskeen: Remove temporaryPath property from d7/File...

Matroskeen closed merge request !186

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.