Problem/Motivation

In core/themes/olivero/templates/block/block--system-branding-block.html.twig, there's an if statement nested inside of an if statement that does not need to exist.

Proposed resolution

Remove the inner if statement

Issue fork drupal-3187884

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kaynen created an issue. See original summary.

kaynen opened merge request !132

kaynen’s picture

kaynen CreditAttribution: kaynen as a volunteer commented
Status: Active » Needs review
stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert at undpaul commented
Status: Needs review » Reviewed & tested by the community

Well that's an easy one :)

Works without breaking anything. Thanks Kaynen!

annikaC’s picture

annikaC CreditAttribution: annikaC as a volunteer commented
Issue tags: +Europe2020

Reviewed and tested by the community over here too - first-time contributor channel on Zoom!

larowlan made their first commit to this issue’s fork.

  • larowlan committed 3caf6df on 9.2.x authored by kaynen 
    Issue #3187884 by kaynen: Remove extra if statement in block--system-...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented
Title: Remove extra if statement in block--system-branding-block.html.twig » [backport] Remove extra if statement in block--system-branding-block.html.twig
Status: Reviewed & tested by the community » Fixed

Thanks, this one is straightforward

Because this isn't a bug, nor major, committing to 9.2 only

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer and at PreviousNext commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.