Convert assertions involving use of xpath on select and option elements to WebAssert

Great work! Readibility so much improved. I have put down the nits below walking through - more food for thought than anything, please do not take them as strict.

In general:

• I wonder if we should check uniqueness of some of the selects, because it seems to me we were doing it before in some cases, and no longer
• In some places taking away the $message should be balanced by some inline context comment

Walkthrough:

1. +++ b/core/modules/ckeditor/tests/src/Functional/CKEditorLoadingTest.php
   @@ -130,9 +130,8 @@ public function testLoading() {
   -    $this->assertCount(1, $format_selector, 'A single text format selector exists on the page.');
   -    $specific_format_selector = $this->xpath('//select[contains(@class, "filter-list") and @data-editor-for="edit-body-0-value"]');
   -    $this->assertCount(1, $specific_format_selector, 'A single text format selector exists on the page and has a "data-editor-for" attribute with the correct value.');
   +    $select = $this->assertSession()->elementExists('css', 'select.js-filter-list');
   +    $this->assertSame('edit-body-0-value', $select->getAttribute('data-editor-for'));
   

   We're missing the uniqueness check here. Some of the $message info could be inlined as comment.

2. +++ b/core/modules/editor/tests/src/Functional/EditorAdminTest.php
   @@ -248,13 +244,11 @@ protected function verifyUnicornEditorConfiguration($format_id, $ponies_too = TR
   -    $this->assertTrue($options[1]->hasAttribute('selected'), 'Option 2 ("Unicorn Editor") is selected.');
   ...
   +    $this->assertTrue($options[1]->isSelected());
   

   Message->comment

3. +++ b/core/modules/editor/tests/src/Functional/EditorLoadingTest.php
   @@ -147,11 +147,11 @@ public function testLoading() {
   -    $this->assertCount(0, $format_selector, 'No text format selector exists on the page because the user only has access to a single format.');
   +    $this->assertSession()->elementNotExists('css', 'select.js-filter-list');
   

   Message->comment

4. +++ b/core/modules/editor/tests/src/Functional/EditorLoadingTest.php
   @@ -175,9 +175,8 @@ public function testLoading() {
   -    $this->assertCount(1, $format_selector, 'A single text format selector exists on the page.');
   -    $specific_format_selector = $this->xpath('//select[contains(@class, "filter-list") and @data-editor-for="edit-body-0-value"]');
   -    $this->assertCount(1, $specific_format_selector, 'A single text format selector exists on the page and has a "data-editor-for" attribute with the correct value.');
   +    $select = $this->assertSession()->elementExists('css', 'select.js-filter-list');
   +    $this->assertSame('edit-body-0-value', $select->getAttribute('data-editor-for'));
   

   Message->comment, uniqueness?

5. +++ b/core/modules/editor/tests/src/Functional/EditorLoadingTest.php
   @@ -270,13 +269,13 @@ public function testSupportedElementTypes() {
   -    $this->assertCount(1, $format_selector, 'A single text format selector exists on the page.');
   -    $specific_format_selector = $this->xpath('//select[contains(@class, "filter-list") and contains(@class, "editor") and @data-editor-for="edit-field-text-0-value"]');
   -    $this->assertCount(1, $specific_format_selector, 'A single text format selector exists on the page and has the "editor" class and a "data-editor-for" attribute with the correct value.');
   +    $select = $this->assertSession()->elementExists('css', 'select.js-filter-list');
   +    $this->assertStringContainsString('editor', $select->getAttribute('class'));
   +    $this->assertSame('edit-field-text-0-value', $select->getAttribute('data-editor-for'));
   

   Message->comment, uniqueness?

6. +++ b/core/modules/editor/tests/src/Functional/EditorLoadingTest.php
   @@ -286,13 +285,13 @@ public function testSupportedElementTypes() {
   -    $this->assertCount(1, $format_selector, 'A single text format selector exists on the page.');
   -    $specific_format_selector = $this->xpath('//select[contains(@class, "filter-list") and contains(@class, "editor") and @data-editor-for="edit-field-text-0-value"]');
   -    $this->assertCount(0, $specific_format_selector, 'No text format selector exists on the page with the "editor" class and a "data-editor-for" attribute with the expected value.');
   +    $select = $this->assertSession()->elementExists('css', 'select.js-filter-list');
   +    $this->assertStringNotContainsString('editor', $select->getAttribute('class'));
   +    $this->assertNotSame('edit-field-text-0-value', $select->getAttribute('data-editor-for'));
   

   again

7. +++ b/core/modules/field/tests/src/Functional/EntityReference/EntityReferenceAdminTest.php
   @@ -390,21 +390,11 @@ protected function createEntityReferenceField($target_type, $bundles = []) {
   -    $xpath = $this->assertSession()->buildXPathQuery('//select[@name=:name]', [':name' => $name]);
   -    $fields = $this->xpath($xpath);
   -    if ($fields) {
   -      $field = $fields[0];
   -      $options = $field->findAll('xpath', 'option');
   -      array_walk($options, function (NodeElement &$option) {
   -        $option = $option->getValue();
   -      });
   -      sort($options);
   -      sort($expected_options);
   -      $this->assertIdentical($options, $expected_options);
   -    }
   -    else {
   -      $this->fail('Unable to find field ' . $name);
   -    }
   +    $options = $this->assertSession()->selectExists($name)->findAll('xpath', 'option');
   +    array_walk($options, function (NodeElement &$option) {
   +      $option = $option->getValue();
   +    });
   +    $this->assertEqualsCanonicalizing($expected_options, $options);
      }
   

   very nice

#7.1 - yeah but not so many of them, and something like this

    $options = $this->assertSession()->selectExists('edit-settings-node-article-settings-language-langcode')->findAll('css', 'option');
    $options = array_map(function ($item) {
      return $item->getValue();
    }, $options);
    $this->assertSame($expected_elements, $options);

seems already quite readable to me. But as you prefer.

#7.2 - well we could use $this->assertSession()->elementsCount() with $count = 1, do we really need a separate method?

Code style not passing.

Created an issue for failing the Custom Commands script not setting the issue status back to Needs Work automagically.
(#3189649: Failing Custom Commands script doesn't change issue status from Needs Review to Needs Work)

Attached patch addresses Code Style failures in #9

Trying to keep up The Good Fight Against TestBot Failures with attached patch

Looks all good! RTBC

Random test fluke, back to RTBC per #14

Rerolled patch #12. Please review.

Fixed the issue.

Reroll the patch.

This is really nice clean-up, as evidenced by the diffstat:

28 files changed, 152 insertions, 243 deletions.

Committed/pushed to 9.2.x.

We should backport to 9.1.x to make other backports easier, but that patch doesn't apply so needs a re-roll.

I m working

New rollout performed for version 9.1.x

Verified patch#30. RTBC +1.

Committed/pushed to 9.1.x, thanks!