Problem/Motivation

Since Drupal 9.1 a number of our dependencies have released minor updates.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 interdiff.3187025.2-6.txt2.38 KBlongwave
#6 3187025-6.patch94.17 KBlongwave
#4 interdiff_2_4.txt848 bytesanmolgoyal74
#4 3187025-4.patch93.8 KBanmolgoyal74
#2 3187025-2.patch93 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3187025-2.patch93 KB 
+------------------------------+---------+---------+
| Production Changes           | From    | To      |
+------------------------------+---------+---------+
| composer/semver              | 3.2.2   | 3.2.4   |
| egulias/email-validator      | 2.1.22  | 2.1.24  |
| laminas/laminas-stdlib       | 3.3.0   | 3.3.1   |
| symfony/console              | v4.4.16 | v4.4.17 |
| symfony/debug                | v4.4.16 | v4.4.17 |
| symfony/dependency-injection | v4.4.16 | v4.4.17 |
| symfony/error-handler        | v4.4.16 | v4.4.17 |
| symfony/event-dispatcher     | v4.4.16 | v4.4.17 |
| symfony/http-foundation      | v4.4.16 | v4.4.17 |
| symfony/http-kernel          | v4.4.16 | v4.4.17 |
| symfony/process              | v4.4.16 | v4.4.17 |
| symfony/routing              | v4.4.16 | v4.4.17 |
| symfony/serializer           | v4.4.16 | v4.4.17 |
| symfony/translation          | v4.4.16 | v4.4.17 |
| symfony/validator            | v4.4.16 | v4.4.17 |
| symfony/yaml                 | v4.4.16 | v4.4.17 |
+------------------------------+---------+---------+

+------------------------------------+---------+---------+
| Dev Changes                        | From    | To      |
+------------------------------------+---------+---------+
| composer/composer                  | 2.0.2   | 2.0.8   |
| composer/spdx-licenses             | 1.5.4   | 1.5.5   |
| composer/xdebug-handler            | 1.4.4   | 1.4.5   |
| doctrine/instantiator              | 1.3.1   | 1.4.0   |
| drupal/coder                       | 8.3.10  | 8.3.11  |
| easyrdf/easyrdf                    | 1.0.0   | 1.1.1   |
| myclabs/deep-copy                  | 1.10.1  | 1.10.2  |
| phar-io/manifest                   | 1.0.3   | 2.0.1   |
| phar-io/version                    | 2.0.1   | 3.0.3   |
| phpunit/php-code-coverage          | 7.0.10  | 7.0.14  |
| phpunit/php-file-iterator          | 2.0.2   | 2.0.3   |
| phpunit/php-timer                  | 2.1.2   | 2.1.3   |
| phpunit/php-token-stream           | 3.1.1   | 4.0.4   |
| phpunit/phpunit                    | 8.5.8   | 8.5.13  |
| sebastian/code-unit-reverse-lookup | 1.0.1   | 1.0.2   |
| sebastian/comparator               | 3.0.2   | 3.0.3   |
| sebastian/diff                     | 3.0.2   | 3.0.3   |
| sebastian/environment              | 4.2.3   | 4.2.4   |
| sebastian/exporter                 | 3.1.2   | 3.1.3   |
| sebastian/global-state             | 3.0.0   | 3.0.1   |
| sebastian/object-enumerator        | 3.0.3   | 3.0.4   |
| sebastian/object-reflector         | 1.1.1   | 1.1.2   |
| sebastian/recursion-context        | 3.0.0   | 3.0.1   |
| sebastian/resource-operations      | 2.0.1   | 2.0.2   |
| sebastian/type                     | 1.1.3   | 1.1.4   |
| seld/jsonlint                      | 1.8.2   | 1.8.3   |
| sirbrillig/phpcs-variable-analysis | v2.9.0  | v2.10.0 |
| symfony/browser-kit                | v4.4.16 | v4.4.17 |
| symfony/css-selector               | v4.4.16 | v4.4.17 |
| symfony/dom-crawler                | v4.4.16 | v4.4.17 |
| symfony/filesystem                 | v4.4.16 | v4.4.17 |
| symfony/finder                     | v4.4.16 | v4.4.17 |
| symfony/lock                       | v4.4.16 | v4.4.17 |
+------------------------------------+---------+---------+

Status: Needs review » Needs work

The last submitted patch, 2: 3187025-2.patch, failed testing. View results

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
3187025-4.patch93.8 KB
interdiff_2_4.txt848 bytes

Status: Needs review » Needs work

The last submitted patch, 4: 3187025-4.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review
FileSize
3187025-6.patch94.17 KB
interdiff.3187025.2-6.txt2.38 KB

Accidentally removed the PHPUnit 9 upgrade in #2.

The expectExceptionMessageRegExp() warning has changed in PHPUnit 8.5.9, I added both to the warning listener for the time being as it can't hurt.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Needs work 
+++ b/core/tests/Drupal/Tests/Traits/PhpUnitWarnings.php
@@ -35,6 +35,7 @@
     'expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9.',
+    'expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.',

Just a question: We have added the second line, then should we not removed the first one?

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

This is what I was talking about at the end of #6. I think we should keep both lines there because we haven't bumped the minimum version of PHPUnit, so if someone installs PHPUnit 8.5.8 or earlier (for example when doing min-max testing) the tests will fail without the first line being there, as the message was changed in PHPUnit 8.5.9. It can't hurt anything by having the message there and we will remove both lines when we drop support for PHPUnit 8.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs work » Reviewed & tested by the community

With the explanation of @longwave in comment #8 is the patch for me RTBC.
All dependency updates a minor updates.
It all looks good to me.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

As per comments on #3183656-15: Fix 'Drupal.Commenting.DocComment.TagGroupSpacing' coding standard [part 2] do we want to request a new Coder version 8.3.12 then use that here? I think that would be worth it, as there have been a few enhancements and fixes since 8.3.11, specifically

  • catch committed 3c2db2e on 9.2.x 
    Issue #3187025 by longwave, anmolgoyal74: Update dependencies for Drupal...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Fine to update coder, but that can happen in the next round of updates - we'll need at least one or two more before 9.2.0, so don't think it needs to hold up this one.

Committed 3c2db2e and pushed to 9.2.x. Thanks!

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

OK, that's great. Thanks for the info.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

@klausi has just released Coder 8.3.12

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +9.2.0 release notes

Release notes always for dep updates, please.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.