Problem/Motivation
When creating a new view without a page or block selected, the initial display title is 'Master'.
Following the lead of #2275877: Replace "master/slave" terminology with "primary/replica", this should be changed.
Views already refers to the master display as the default display in some places, so the replacement wording is provided.
Steps to reproduce
Create a new view without creating a block or page and save, the initial display title is 'Master'.
Proposed resolution
- Update the initial view display name title to 'Default'
- Change the Views setting wording for /admin/structure/views/settings
Renaming existing displays is out of scope.
Remaining tasks
Replace the word "master" with "default"Write update hook to migrateviews.settings
'sui.show.master_display
to a newui.show.default_display
User interface changes
UI already uses the phrase "Always show the master (default) display", changing to "Always show the default display" is a string change but not disruptive to end users
API changes
N/A
Data model changes
Minor schema change to simple config, no changes to Views config entity schema
Release notes snippet
Views renamed the default display from "Master" to "Default". This does not affect existing Views, only ones created after this change. Additionally the setting to hide/show the default display had its machine name changed from ui.show.master_display
to ui.show.default_display
. Review the change record for more information.
Issue fork drupal-3186582
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3186582-views-display-rename changes, plain diff MR !97
Comments
Comment #3
tim.plunkettStill needs an update hook, but here's a first pass
Comment #5
tim.plunkettMight still need some test fixes, but it's ready for review.
Comment #7
LendudeWent through this again and I think this takes care of all of it.
Since all code already calls this 'default', I think we should be pretty safe from a BC stand point.
And nice that this also takes care of a strange divide in code and labels
Comment #8
alexpottThere's a new one in core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_revision_id_argument.yml to fix. I would have fixed this on commit but I think given that there are test changes and we're changing a default value that ends up in config we should have a release note and CR so that if someone is relying on the old terminology in there tests we'll have a CR to explain why they are now failing.
The update and config change look great.
Comment #9
tim.plunkettRebased branch so I could change the view, then changed the view.
CR is at https://www.drupal.org/node/3189589
Attempted a release note snippet.
Setting back to RTBC.
Comment #10
alexpottCommitted 85ac7f5 and pushed to 9.2.x. Thanks!
Comment #14
effulgentsia CreditAttribution: effulgentsia at Acquia commented