Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Modernizr released 3.11.7 several weeks ago.
Proposed resolution
Update to the latest version.
Release notes snippet
Modernizr is updated to v3.11.7
Comment | File | Size | Author |
---|
Issue fork drupal-3185165
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3185165-update-modernizr-to changes, plain diff MR !486
Comments
Comment #2
bfurner CreditAttribution: bfurner commentedThis is an issue in version 8.9.x as well
Comment #3
vipin.mittal18Comment #4
vipin.mittal18Upgraded to modernizr@3.6.0 to support the browser features details-inputtypes-touchevents-addtest-prefixes-setclasses-teststyles. Refer attached patch for the solution.
Comment #5
catchNeeds a re-roll.
Comment #6
Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commentedRe-rolled patch.
Comment #8
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented#6 is green so it's ready for review.
Comment #9
SpokjeNot quite sure what happened but in #4:
Whilst the Issue Summary stated:
Looking at the patch #6 it looks like it is actually downgrading Modernizr from the current 3.8.0 to 3.6.0.
I also saw that the current latest release of Modernizr is 3.11.6
Comment #10
SpokjeHmmm,
Somehow no matter what version your trying to download through the URL https://modernizr.com/download/?-details-inputtypes-addtest-mq-prefixed-prefixes-setclasses-teststyles the header will always show the version number as:
/*! modernizr 3.6.0 (Custom Build) | MIT *
With hesitation I've manually updated the header to the version I've actually downloaded:
/*! modernizr 3.11.6 (Custom Build) | MIT *
Patch attached.
No interdiff, since they're kinda useless on one-line minified scripts.
Comment #11
SpokjeLooking through some old issues on updating Modernizr, I stumbled over this comment:
I followed the above procedure and added a patch with the real 3.11.6
Since the procedure is easy to forget when the time comes for another Modernizr update, I've also added a
README.md
tocore/assets/vendor/modernizr
with the above procedure.Comment #13
SpokjeComment #14
mherchelComment #15
SpokjeComment #16
SpokjeThanks for the heads-up @mherchel, latest MR code opdates modernizer from 3.8.0 => 3.11.7
Comment #18
mherchelLooks great!
RTBC!
Comment #19
SpokjePutting this back to Version
9.2.x
because I think a new Minor Release of Core deserves the latest and greatest included.Comment #20
alexpottCommitted and pushed 61a07efcc7 to 9.3.x and 6967b53c5d to 9.2.x. Thanks!